From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 08/13] simple changes in gdb.base
Date: Tue, 27 Aug 2013 13:31:00 -0000 [thread overview]
Message-ID: <521CAA1D.9050405@redhat.com> (raw)
In-Reply-To: <1377290210-483-9-git-send-email-tromey@redhat.com>
On 08/23/2013 09:36 PM, Tom Tromey wrote:
> +
> +foreach file $all_files {
> + if {[is_remote host]} {
> + set this_name $file
> + } else {
> + set this_name [standard_output_file $file]
> + }
> +
> + lappend filenames [set ${file} $this_name]
Took me a second to realize/notice it's this loop that
creates the intarr1.bin etc. variables used in:
> +make_dump_file "dump val [set intarr1.bin] intarray"
etc. How about adding a comment here, or above the loop?
> +}
> +
> +remote_exec host "rm -f $filenames"
>
> # Test help (FIXME:)
>
> @@ -96,34 +115,34 @@ proc make_dump_file { command msg } {
> }
> }
>
> -make_dump_file "dump val intarr1.bin intarray" \
> +make_dump_file "dump val [set intarr1.bin] intarray" \
> "dump array as value, default"
> --- a/gdb/testsuite/gdb.base/dump.exp
> +++ b/gdb/testsuite/gdb.base/dump.exp
> @@ -63,7 +63,26 @@ if {${data_address} > ${max_32bit_address}} then {
>
> # Clean up any stale output files from previous test runs
>
> -remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec"
...
> +remote_exec host "rm -f $filenames"
...
> # clean up files
>
> -remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec"
> +remote_exec build "rm -f $filenames"
s/build/host ?
>
> -set solib_binfile_target [gdb_download ${solib_binfile}]
> +if {[is_remote target]} {
> + set solib_binfile_target [gdb_download ${solib_binfile}]
> +} else {
> + set solib_binfile_target $solib_binfile
> +}
>
Sounds like this should be using gdb_load_shlibs.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-27 13:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 20:36 [PATCH 00/13] test suite parallel safety Tom Tromey
2013-08-23 20:36 ` [PATCH 04/13] fix up gdb.gdb Tom Tromey
2013-08-23 20:36 ` [PATCH 06/13] fix up gdb.mi Tom Tromey
2013-08-25 1:50 ` Yao Qi
2013-10-17 18:45 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 10/13] update fileio test Tom Tromey
2013-08-23 20:37 ` [PATCH 08/13] simple changes in gdb.base Tom Tromey
2013-08-27 13:31 ` Pedro Alves [this message]
2013-10-17 19:58 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 03/13] fix weird.exp for parallel testing Tom Tromey
2013-08-23 20:37 ` [PATCH 12/13] fix up gdb.server Tom Tromey
2013-08-23 20:37 ` [PATCH 11/13] introduce relative_filename and use it Tom Tromey
2013-08-27 13:44 ` Pedro Alves
2013-10-17 18:59 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 07/13] fix up gdb.trace Tom Tromey
2013-08-27 12:26 ` Pedro Alves
2013-10-17 18:56 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 02/13] fix some simple thinkos in the test suite Tom Tromey
2013-08-23 20:37 ` [PATCH 05/13] fix up gdb.xml Tom Tromey
2013-08-27 12:12 ` Pedro Alves
2013-10-17 18:42 ` Tom Tromey
2013-10-18 15:20 ` Pedro Alves
2013-08-23 20:37 ` [PATCH 13/13] make gdb.asm parallel-safe Tom Tromey
2013-08-27 13:48 ` Pedro Alves
2013-08-27 14:06 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 01/13] fix up log-file toggling Tom Tromey
2013-08-23 20:37 ` [PATCH 09/13] update checkpoint test Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521CAA1D.9050405@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox