From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2121 invoked by alias); 27 Aug 2013 13:31:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2112 invoked by uid 89); 27 Aug 2013 13:31:14 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 13:31:14 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7RDVBJL025149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 Aug 2013 09:31:11 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7RDV9CM006226; Tue, 27 Aug 2013 09:31:10 -0400 Message-ID: <521CAA1D.9050405@redhat.com> Date: Tue, 27 Aug 2013 13:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 08/13] simple changes in gdb.base References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-9-git-send-email-tromey@redhat.com> In-Reply-To: <1377290210-483-9-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00782.txt.bz2 On 08/23/2013 09:36 PM, Tom Tromey wrote: > + > +foreach file $all_files { > + if {[is_remote host]} { > + set this_name $file > + } else { > + set this_name [standard_output_file $file] > + } > + > + lappend filenames [set ${file} $this_name] Took me a second to realize/notice it's this loop that creates the intarr1.bin etc. variables used in: > +make_dump_file "dump val [set intarr1.bin] intarray" etc. How about adding a comment here, or above the loop? > +} > + > +remote_exec host "rm -f $filenames" > > # Test help (FIXME:) > > @@ -96,34 +115,34 @@ proc make_dump_file { command msg } { > } > } > > -make_dump_file "dump val intarr1.bin intarray" \ > +make_dump_file "dump val [set intarr1.bin] intarray" \ > "dump array as value, default" > --- a/gdb/testsuite/gdb.base/dump.exp > +++ b/gdb/testsuite/gdb.base/dump.exp > @@ -63,7 +63,26 @@ if {${data_address} > ${max_32bit_address}} then { > > # Clean up any stale output files from previous test runs > > -remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec" ... > +remote_exec host "rm -f $filenames" ... > # clean up files > > -remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec" > +remote_exec build "rm -f $filenames" s/build/host ? > > -set solib_binfile_target [gdb_download ${solib_binfile}] > +if {[is_remote target]} { > + set solib_binfile_target [gdb_download ${solib_binfile}] > +} else { > + set solib_binfile_target $solib_binfile > +} > Sounds like this should be using gdb_load_shlibs. -- Pedro Alves