From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 07/13] fix up gdb.trace
Date: Thu, 17 Oct 2013 18:56:00 -0000 [thread overview]
Message-ID: <87a9i7vi8y.fsf@fleche.redhat.com> (raw)
In-Reply-To: <521C9AF4.4050704@redhat.com> (Pedro Alves's message of "Tue, 27 Aug 2013 13:26:28 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> ... not this one. I'd move all defaults to this else
Pedro> block. Same in tfile.exp.
Done.
>> -# Make sure we are starting fresh.
>> -remote_file host delete tfile-basic.tf
>> -remote_file target delete tfile-basic.tf
>> +if {!$purely_local} {
>> + # Make sure we are starting fresh.
>> + remote_file host delete tfile-basic.tf
>> + remote_file target delete tfile-basic.tf
>> +}
Pedro> Shouldn't we delete the previous version of the file
Pedro> in local mode? tfile.exp does keep this unconditional.
Done.
>> -gdb_test "target tfile tfile-basic.tf" "Created tracepoint.*" \
>> +gdb_test "target tfile $tfile_basic" "Created tracepoint.*" \
>> "target tfile"
>>
>> gdb_test "info trace" ".*tracepoint.*in write_basic_trace_file.*" \
>> @@ -108,7 +125,7 @@ gdb_start
>>
>> gdb_load $binfile
>>
>> -gdb_test "target tfile tfile-error.tf" "Created tracepoint.*" \
>> +gdb_test "target tfile $tfile_error" "Created tracepoint.*" \
>> "target tfile"
Pedro> This seems to introduce duplicated messages in gdb.sum.
Fixed.
Pedro> (A good exercise would be to compare gdb.sum before/after whole series.)
Yeah, I did do that, and I believe my comparison script handles
duplicates properly. But I will redo it before resending the branch.
Tom
prev parent reply other threads:[~2013-10-17 18:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 20:36 [PATCH 00/13] test suite parallel safety Tom Tromey
2013-08-23 20:36 ` [PATCH 04/13] fix up gdb.gdb Tom Tromey
2013-08-23 20:36 ` [PATCH 06/13] fix up gdb.mi Tom Tromey
2013-08-25 1:50 ` Yao Qi
2013-10-17 18:45 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 09/13] update checkpoint test Tom Tromey
2013-08-23 20:37 ` [PATCH 02/13] fix some simple thinkos in the test suite Tom Tromey
2013-08-23 20:37 ` [PATCH 05/13] fix up gdb.xml Tom Tromey
2013-08-27 12:12 ` Pedro Alves
2013-10-17 18:42 ` Tom Tromey
2013-10-18 15:20 ` Pedro Alves
2013-08-23 20:37 ` [PATCH 13/13] make gdb.asm parallel-safe Tom Tromey
2013-08-27 13:48 ` Pedro Alves
2013-08-27 14:06 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 01/13] fix up log-file toggling Tom Tromey
2013-08-23 20:37 ` [PATCH 08/13] simple changes in gdb.base Tom Tromey
2013-08-27 13:31 ` Pedro Alves
2013-10-17 19:58 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 10/13] update fileio test Tom Tromey
2013-08-23 20:37 ` [PATCH 03/13] fix weird.exp for parallel testing Tom Tromey
2013-08-23 20:37 ` [PATCH 12/13] fix up gdb.server Tom Tromey
2013-08-23 20:37 ` [PATCH 11/13] introduce relative_filename and use it Tom Tromey
2013-08-27 13:44 ` Pedro Alves
2013-10-17 18:59 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 07/13] fix up gdb.trace Tom Tromey
2013-08-27 12:26 ` Pedro Alves
2013-10-17 18:56 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9i7vi8y.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox