From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 05/13] fix up gdb.xml
Date: Tue, 27 Aug 2013 12:12:00 -0000 [thread overview]
Message-ID: <521C97AE.4040707@redhat.com> (raw)
In-Reply-To: <1377290210-483-6-git-send-email-tromey@redhat.com>
On 08/23/2013 09:36 PM, Tom Tromey wrote:
> diff --git a/gdb/testsuite/gdb.xml/tdesc-arch.exp b/gdb/testsuite/gdb.xml/tdesc-arch.exp
> index 5fde2ff..be0b9f1 100644
> --- a/gdb/testsuite/gdb.xml/tdesc-arch.exp
> +++ b/gdb/testsuite/gdb.xml/tdesc-arch.exp
> @@ -60,17 +60,20 @@ proc set_arch { arch which } {
> global gdb_prompt
> global subdir
>
> - set fd [open "$subdir/tdesc-arch.xml" w]
> + set filename [standard_output_file tdesc-arch.xml]
> + set fd [open $filename w]
> puts $fd \
> "<target>
> <architecture>$arch</architecture>
> </target>"
> close $fd
> - remote_download host "${subdir}/tdesc-arch.xml" "tdesc-arch.xml"
> + if {[is_remote host]} {
> + set filename [remote_download host $filename tdesc-arch.xml]
> + }
>
> # Anchor the test output, so that error messages are detected.
> - set cmd "set tdesc filename tdesc-arch.xml"
> - set msg "$cmd ($which architecture)"
> + set cmd "set tdesc filename $filename"
> + set msg "set tdesc filename ($which architecture)"
Should be:
set msg "set tdesc filename tdesc-arch.xml ($which architecture)"
> -set cmd "set tdesc filename tdesc-arch.xml"
> +set cmd "set tdesc filename $filename"
> gdb_test $cmd \
> "warning:.*Target description specified unknown architecture.*" \
> - "$cmd (invalid architecture)"
> + "set tdesc filename tdesc-arch.xml (invalid architecture)"
(Like here.)
> set cmd_regex [string_to_regexp $cmd]
> gdb_test_multiple $cmd $msg {
> -re "^$cmd_regex\r\n$gdb_prompt $" {
> @@ -86,31 +89,32 @@ proc set_arch { arch which } {
> "The target architecture is set automatically \\(currently $arch\\)" \
> "$cmd ($which architecture)"
>
> - file delete "${subdir}/tdesc-arch.xml"
> - remote_file host delete "tdesc-arch.xml"
> + remote_file host delete $filename
I noticed this seems to leave the build machine's copy
behind. Was that on purpose?
> }
> # Similarly, we need to copy files under test into the objdir.
> -proc load_description { file errmsg } {
> +proc load_description { file errmsg {should_cd 1} } {
Could you add a comment on the should_cd parameter please?
It's not obvious to me why a test should cd, while the other
shouldn't.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-27 12:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 20:36 [PATCH 00/13] test suite parallel safety Tom Tromey
2013-08-23 20:36 ` [PATCH 04/13] fix up gdb.gdb Tom Tromey
2013-08-23 20:36 ` [PATCH 06/13] fix up gdb.mi Tom Tromey
2013-08-25 1:50 ` Yao Qi
2013-10-17 18:45 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 09/13] update checkpoint test Tom Tromey
2013-08-23 20:37 ` [PATCH 05/13] fix up gdb.xml Tom Tromey
2013-08-27 12:12 ` Pedro Alves [this message]
2013-10-17 18:42 ` Tom Tromey
2013-10-18 15:20 ` Pedro Alves
2013-08-23 20:37 ` [PATCH 02/13] fix some simple thinkos in the test suite Tom Tromey
2013-08-23 20:37 ` [PATCH 13/13] make gdb.asm parallel-safe Tom Tromey
2013-08-27 13:48 ` Pedro Alves
2013-08-27 14:06 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 01/13] fix up log-file toggling Tom Tromey
2013-08-23 20:37 ` [PATCH 12/13] fix up gdb.server Tom Tromey
2013-08-23 20:37 ` [PATCH 03/13] fix weird.exp for parallel testing Tom Tromey
2013-08-23 20:37 ` [PATCH 08/13] simple changes in gdb.base Tom Tromey
2013-08-27 13:31 ` Pedro Alves
2013-10-17 19:58 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 10/13] update fileio test Tom Tromey
2013-08-23 20:37 ` [PATCH 11/13] introduce relative_filename and use it Tom Tromey
2013-08-27 13:44 ` Pedro Alves
2013-10-17 18:59 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 07/13] fix up gdb.trace Tom Tromey
2013-08-27 12:26 ` Pedro Alves
2013-10-17 18:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C97AE.4040707@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox