From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19969 invoked by alias); 17 Oct 2013 18:56:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19955 invoked by uid 89); 17 Oct 2013 18:56:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 18:56:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9HIuU0Y013049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Oct 2013 14:56:30 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9HIuTag011488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Oct 2013 14:56:30 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 07/13] fix up gdb.trace References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-8-git-send-email-tromey@redhat.com> <521C9AF4.4050704@redhat.com> Date: Thu, 17 Oct 2013 18:56:00 -0000 In-Reply-To: <521C9AF4.4050704@redhat.com> (Pedro Alves's message of "Tue, 27 Aug 2013 13:26:28 +0100") Message-ID: <87a9i7vi8y.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00535.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> ... not this one. I'd move all defaults to this else Pedro> block. Same in tfile.exp. Done. >> -# Make sure we are starting fresh. >> -remote_file host delete tfile-basic.tf >> -remote_file target delete tfile-basic.tf >> +if {!$purely_local} { >> + # Make sure we are starting fresh. >> + remote_file host delete tfile-basic.tf >> + remote_file target delete tfile-basic.tf >> +} Pedro> Shouldn't we delete the previous version of the file Pedro> in local mode? tfile.exp does keep this unconditional. Done. >> -gdb_test "target tfile tfile-basic.tf" "Created tracepoint.*" \ >> +gdb_test "target tfile $tfile_basic" "Created tracepoint.*" \ >> "target tfile" >> >> gdb_test "info trace" ".*tracepoint.*in write_basic_trace_file.*" \ >> @@ -108,7 +125,7 @@ gdb_start >> >> gdb_load $binfile >> >> -gdb_test "target tfile tfile-error.tf" "Created tracepoint.*" \ >> +gdb_test "target tfile $tfile_error" "Created tracepoint.*" \ >> "target tfile" Pedro> This seems to introduce duplicated messages in gdb.sum. Fixed. Pedro> (A good exercise would be to compare gdb.sum before/after whole series.) Yeah, I did do that, and I believe my comparison script handles duplicates properly. But I will redo it before resending the branch. Tom