From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106421-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32284 invoked by alias); 17 Oct 2013 18:45:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32275 invoked by uid 89); 17 Oct 2013 18:45:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 18:45:48 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9HIjjUZ006272	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 17 Oct 2013 14:45:45 -0400
Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9HIjh23020019	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 17 Oct 2013 14:45:44 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 06/13] fix up gdb.mi
References: <1377290210-483-1-git-send-email-tromey@redhat.com>	<1377290210-483-7-git-send-email-tromey@redhat.com>	<52196299.5050004@codesourcery.com>
Date: Thu, 17 Oct 2013 18:45:00 -0000
In-Reply-To: <52196299.5050004@codesourcery.com> (Yao Qi's message of "Sun, 25	Aug 2013 09:49:13 +0800")
Message-ID: <87eh7jviqw.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-10/txt/msg00534.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

>> # No notification is emitted for 'maint set' commands.
>> foreach boolean_opt { "on" "off" } {
>> -	    mi_gdb_test "maint set profile ${boolean_opt}" \
>> -		"\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
>> -		"\"maint set profile ${boolean_opt}\""
>> +	    mi_gdb_test "maint set dwarf2 always-disassemble ${boolean_opt}" \
>> + "\\&\"maint set dwarf2 always-disassemble
>> ${boolean_opt}\\\\n\"\r\n\\^done" \
>> +		"\"maint dwarf2 always-disassemble ${boolean_opt}\""
>> }

Yao> We replace "maint set profile" with "maint set dwarf2
Yao> always-disassemble", because the former will cause gdb to generate a
Yao> file on exit?

Yes.  The choice of command is incidental to the test, and this change
avoids the appearance of parallel-unsafe-ness.

>> 
>> proc test_file_transfer { filename description } {
>> -    mi_gdb_test "-target-file-put \"$filename\" \"down-server\"" \
>> +    if {![is_remote host] && ![is_remote target]} {
>> +	set up_server [standard_output_file up-server]
>> +	set down_server [standard_output_file down-server]
>> +    } else {
>> +	set up_server up-server
>> +	set down_server down-server
>> +    }
>> +

Yao> IWBN to write comments, IMO.

Done now, thanks.

Tom