From: Yao Qi <yao@codesourcery.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 05/16] Eliminate literal line numbers in ending-run.exp
Date: Thu, 13 Nov 2014 13:44:00 -0000 [thread overview]
Message-ID: <878ujfjjvd.fsf@codesourcery.com> (raw)
In-Reply-To: <1414598446-13831-5-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Wed, 29 Oct 2014 17:00:20 +0100")
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
> @@ -21,7 +21,9 @@
>
> # ending-run.exp -- Expect script to test ending a test run in gdb
>
> -if { [prepare_for_testing ending-run.exp ending-run] } {
> +standard_testfile
> +
> +if { [prepare_for_testing ${testfile}.exp $testfile] } {
> return -1
> }
> remote_exec build "rm -f core"
This change should be moved out of this patch because it isn't related.
The rest of the patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2014-11-13 13:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 15:51 [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11 Andreas Arnez
2014-10-29 16:00 ` [PATCH 01/16] Eliminate literal line numbers in so-impl-ld.exp Andreas Arnez
2014-10-29 16:22 ` Sergio Durigan Junior
2014-10-29 18:26 ` Andreas Arnez
2014-10-29 22:11 ` Sergio Durigan Junior
2014-10-31 20:59 ` Sergio Durigan Junior
2014-11-13 13:15 ` Yao Qi
2014-10-29 16:01 ` [PATCH 04/16] Eliminate literal line numbers in call-rt-st.exp Andreas Arnez
2014-11-13 13:36 ` Yao Qi
2014-10-29 16:01 ` [PATCH 03/16] Eliminate literal line numbers in call-ar-st.exp Andreas Arnez
2014-11-13 13:33 ` Yao Qi
2014-10-29 16:01 ` [PATCH 02/16] Eliminate literal line numbers in dbx.exp Andreas Arnez
2014-11-13 13:18 ` Yao Qi
2014-11-13 14:16 ` Andreas Arnez
2014-11-14 0:26 ` Yao Qi
2014-10-29 16:01 ` [PATCH 05/16] Eliminate literal line numbers in ending-run.exp Andreas Arnez
2014-11-13 13:44 ` Yao Qi [this message]
2014-10-29 16:02 ` [PATCH 06/16] Eliminate literal line numbers in foll-exec.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 07/16] Eliminate literal line numbers in jump.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 09/16] Eliminate literal line numbers in mi-console.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 08/16] Eliminate literal line numbers in shlib-call.exp Andreas Arnez
2014-10-29 16:03 ` [PATCH 12/16] Drop non-prototype C function header variants: 'break' test case Andreas Arnez
2014-10-29 16:03 ` [PATCH 11/16] Drop non-prototype C function header variants: solib1.c Andreas Arnez
2014-10-29 16:03 ` [PATCH 10/16] 'callfuncs' test case: Fix typo in prototyped version Andreas Arnez
2014-10-29 16:04 ` [PATCH 15/16] GDB testsuite: drop non-prototype C function header variants Andreas Arnez
2014-10-29 16:04 ` [PATCH 16/16] GDB testsuite: Fix warnings with -std=gnu11 Andreas Arnez
2014-10-29 16:04 ` [PATCH 14/16] Drop non-prototype C function header variants: 'sepdebug' test case Andreas Arnez
2014-10-29 16:04 ` [PATCH 13/16] Drop non-prototype C function header variants: 'list' " Andreas Arnez
2014-11-12 12:33 ` Pedro Alves
2014-11-12 15:05 ` Andreas Arnez
2014-11-12 15:18 ` Pedro Alves
2014-11-13 14:06 ` [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11 Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ujfjjvd.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox