From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11780 invoked by alias); 13 Nov 2014 13:44:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11766 invoked by uid 89); 13 Nov 2014 13:44:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Nov 2014 13:44:14 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1Xouh1-0001od-Bm from Yao_Qi@mentor.com ; Thu, 13 Nov 2014 05:44:11 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.181.6; Thu, 13 Nov 2014 05:44:10 -0800 From: Yao Qi To: Andreas Arnez CC: Subject: Re: [PATCH 05/16] Eliminate literal line numbers in ending-run.exp References: <1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com> <1414598446-13831-5-git-send-email-arnez@linux.vnet.ibm.com> Date: Thu, 13 Nov 2014 13:44:00 -0000 In-Reply-To: <1414598446-13831-5-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Wed, 29 Oct 2014 17:00:20 +0100") Message-ID: <878ujfjjvd.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00264.txt.bz2 Andreas Arnez writes: > @@ -21,7 +21,9 @@ >=20=20 > # ending-run.exp -- Expect script to test ending a test run in gdb >=20=20 > -if { [prepare_for_testing ending-run.exp ending-run] } { > +standard_testfile > + > +if { [prepare_for_testing ${testfile}.exp $testfile] } { > return -1 > } > remote_exec build "rm -f core" This change should be moved out of this patch because it isn't related. The rest of the patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)