From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 13/16] Drop non-prototype C function header variants: 'list' test case
Date: Wed, 12 Nov 2014 15:05:00 -0000 [thread overview]
Message-ID: <87sihoxxwf.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <5463538A.4090508@redhat.com> (Pedro Alves's message of "Wed, 12 Nov 2014 12:33:14 +0000")
On Wed, Nov 12 2014, Pedro Alves wrote:
> On 10/29/2014 04:00 PM, Andreas Arnez wrote:
>> Remove old-style function header variants from list0.h and list1.c.
>> Fill the removed lines with comments or empty lines, such that the
>> line numbering is undisturbed.
>
> Why is it important that the line numbering is undisturbed?
Changes to the line numbering would require heavy adjustments to
list.exp. Many line numbers are hard-coded, as well as a fair amount of
knowledge about the source code in and around certain lines. Thus the
dependency on the line numbering can not be eliminated so easily here,
and it may not even be a useful goal for a "list" test case. Another
option might be to adjust the literal line numbers in list.exp, but even
that is not as straightforward as it may seem, since the test case
expects certain source lines to be exactly n lines apart.
I'll add the above explanation to the commit message, OK?
next prev parent reply other threads:[~2014-11-12 15:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 15:51 [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11 Andreas Arnez
2014-10-29 16:00 ` [PATCH 01/16] Eliminate literal line numbers in so-impl-ld.exp Andreas Arnez
2014-10-29 16:22 ` Sergio Durigan Junior
2014-10-29 18:26 ` Andreas Arnez
2014-10-29 22:11 ` Sergio Durigan Junior
2014-10-31 20:59 ` Sergio Durigan Junior
2014-11-13 13:15 ` Yao Qi
2014-10-29 16:01 ` [PATCH 05/16] Eliminate literal line numbers in ending-run.exp Andreas Arnez
2014-11-13 13:44 ` Yao Qi
2014-10-29 16:01 ` [PATCH 02/16] Eliminate literal line numbers in dbx.exp Andreas Arnez
2014-11-13 13:18 ` Yao Qi
2014-11-13 14:16 ` Andreas Arnez
2014-11-14 0:26 ` Yao Qi
2014-10-29 16:01 ` [PATCH 03/16] Eliminate literal line numbers in call-ar-st.exp Andreas Arnez
2014-11-13 13:33 ` Yao Qi
2014-10-29 16:01 ` [PATCH 04/16] Eliminate literal line numbers in call-rt-st.exp Andreas Arnez
2014-11-13 13:36 ` Yao Qi
2014-10-29 16:02 ` [PATCH 08/16] Eliminate literal line numbers in shlib-call.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 09/16] Eliminate literal line numbers in mi-console.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 07/16] Eliminate literal line numbers in jump.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 06/16] Eliminate literal line numbers in foll-exec.exp Andreas Arnez
2014-10-29 16:03 ` [PATCH 10/16] 'callfuncs' test case: Fix typo in prototyped version Andreas Arnez
2014-10-29 16:03 ` [PATCH 11/16] Drop non-prototype C function header variants: solib1.c Andreas Arnez
2014-10-29 16:03 ` [PATCH 12/16] Drop non-prototype C function header variants: 'break' test case Andreas Arnez
2014-10-29 16:04 ` [PATCH 13/16] Drop non-prototype C function header variants: 'list' " Andreas Arnez
2014-11-12 12:33 ` Pedro Alves
2014-11-12 15:05 ` Andreas Arnez [this message]
2014-11-12 15:18 ` Pedro Alves
2014-10-29 16:04 ` [PATCH 14/16] Drop non-prototype C function header variants: 'sepdebug' " Andreas Arnez
2014-10-29 16:04 ` [PATCH 16/16] GDB testsuite: Fix warnings with -std=gnu11 Andreas Arnez
2014-10-29 16:04 ` [PATCH 15/16] GDB testsuite: drop non-prototype C function header variants Andreas Arnez
2014-11-13 14:06 ` [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11 Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sihoxxwf.fsf@br87z6lw.de.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox