From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11
Date: Wed, 29 Oct 2014 15:51:00 -0000 [thread overview]
Message-ID: <1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com> (raw)
This patch set was triggered by the fact that upstream GCC has changed
the default C language dialect to 'gnu11':
https://gcc.gnu.org/ml/gcc/2014-10/msg00053.html
While the GDB source code doesn't seem to have any issues with that,
the test suite has, because it contains many functions without return
types and lots of implicit function declarations.
But while fixing these, I noticed that many test cases still rely on
literal line numbers and thus would fail after fixing the warnings.
Thus the first part of the patch set deals with eliminating literal
line numbers from various test cases.
Another observation is that many existing C source files in the test
suite contain code like this:
#ifdef PROTOTYPES
<prototyped function header>
#else
<old-style function header>
#endif
And that the prototyped variant would sometimes *fix* the warning.
However, the PROTOTYPES macro is never defined, hence the old-style
version is always used. Thus the second part of the patch series
performs some clean-up in this area by consequently migrating to the
prototyped variants and getting rid of such preprocessor conditionals.
The final part of the series then fixes the remaining warnings.
Andreas Arnez (16):
Eliminate literal line numbers in so-impl-ld.exp
Eliminate literal line numbers in dbx.exp
Eliminate literal line numbers in call-ar-st.exp
Eliminate literal line numbers in call-rt-st.exp
Eliminate literal line numbers in ending-run.exp
Eliminate literal line numbers in foll-exec.exp
Eliminate literal line numbers in jump.exp
Eliminate literal line numbers in shlib-call.exp
Eliminate literal line numbers in mi-console.exp
'callfuncs' test case: Fix typo in prototyped version
Drop non-prototype C function header variants: solib1.c
Drop non-prototype C function header variants: 'break' test case
Drop non-prototype C function header variants: 'list' test case
Drop non-prototype C function header variants: 'sepdebug' test case
GDB testsuite: drop non-prototype C function header variants
GDB testsuite: Fix warnings with -std=gnu11
gdb/testsuite/gdb.ada/cond_lang/foo.c | 2 +-
gdb/testsuite/gdb.base/advance.c | 10 +-
gdb/testsuite/gdb.base/annota1.c | 13 -
gdb/testsuite/gdb.base/annota3.c | 13 -
gdb/testsuite/gdb.base/async-shell.c | 2 +
gdb/testsuite/gdb.base/async.c | 28 +-
gdb/testsuite/gdb.base/attach-pie-misread.c | 1 +
gdb/testsuite/gdb.base/attach-twice.c | 1 +
gdb/testsuite/gdb.base/average.c | 17 +-
gdb/testsuite/gdb.base/break-interp-lib.c | 1 +
gdb/testsuite/gdb.base/break.c | 29 --
gdb/testsuite/gdb.base/break.exp | 29 +-
gdb/testsuite/gdb.base/break1.c | 7 -
gdb/testsuite/gdb.base/call-ar-st.c | 308 +--------------
gdb/testsuite/gdb.base/call-ar-st.exp | 165 ++++----
gdb/testsuite/gdb.base/call-rt-st.c | 157 +-------
gdb/testsuite/gdb.base/call-rt-st.exp | 11 +-
gdb/testsuite/gdb.base/call-sc.c | 7 +-
gdb/testsuite/gdb.base/call-strs.c | 22 --
gdb/testsuite/gdb.base/callfuncs.c | 131 +------
gdb/testsuite/gdb.base/catch-signal-fork.c | 2 +
gdb/testsuite/gdb.base/checkpoint.c | 7 +-
gdb/testsuite/gdb.base/code_elim2.c | 12 +-
gdb/testsuite/gdb.base/coremaker.c | 1 +
gdb/testsuite/gdb.base/dbx.exp | 16 +-
gdb/testsuite/gdb.base/dprintf-non-stop.c | 2 +
gdb/testsuite/gdb.base/dump.c | 2 +
gdb/testsuite/gdb.base/ending-run.c | 9 +-
gdb/testsuite/gdb.base/ending-run.exp | 38 +-
gdb/testsuite/gdb.base/execd-prog.c | 8 +-
gdb/testsuite/gdb.base/exprs.c | 7 -
gdb/testsuite/gdb.base/fileio.c | 1 +
gdb/testsuite/gdb.base/foll-exec.c | 8 +-
gdb/testsuite/gdb.base/foll-exec.exp | 37 +-
gdb/testsuite/gdb.base/foll-fork.c | 9 -
gdb/testsuite/gdb.base/foll-vfork.c | 4 -
gdb/testsuite/gdb.base/funcargs.c | 334 ----------------
gdb/testsuite/gdb.base/gcore.c | 6 +-
gdb/testsuite/gdb.base/global-var-nested-by-dso.c | 3 +
gdb/testsuite/gdb.base/huge.c | 1 +
gdb/testsuite/gdb.base/inferior-died.c | 1 +
gdb/testsuite/gdb.base/info-os.c | 1 +
gdb/testsuite/gdb.base/jump.c | 11 +-
gdb/testsuite/gdb.base/jump.exp | 29 +-
gdb/testsuite/gdb.base/langs0.c | 6 -
gdb/testsuite/gdb.base/langs1.c | 8 -
gdb/testsuite/gdb.base/langs2.c | 17 -
gdb/testsuite/gdb.base/list0.h | 8 +-
gdb/testsuite/gdb.base/list1.c | 20 +-
gdb/testsuite/gdb.base/mips_pro.c | 25 --
gdb/testsuite/gdb.base/multi-forks.c | 3 +-
gdb/testsuite/gdb.base/nodebug.c | 32 --
gdb/testsuite/gdb.base/opaque0.c | 2 -
gdb/testsuite/gdb.base/opaque1.c | 5 -
gdb/testsuite/gdb.base/pr10179-a.c | 1 +
gdb/testsuite/gdb.base/recurse.c | 6 -
gdb/testsuite/gdb.base/run.c | 11 -
gdb/testsuite/gdb.base/savedregs.c | 2 +
gdb/testsuite/gdb.base/scope0.c | 29 --
gdb/testsuite/gdb.base/scope1.c | 4 -
gdb/testsuite/gdb.base/sepdebug.c | 29 --
gdb/testsuite/gdb.base/sepdebug.exp | 30 +-
gdb/testsuite/gdb.base/setshow.c | 7 -
gdb/testsuite/gdb.base/setvar.c | 7 -
gdb/testsuite/gdb.base/shlib-call.exp | 2 +-
gdb/testsuite/gdb.base/shmain.c | 10 -
gdb/testsuite/gdb.base/shr1.c | 20 -
gdb/testsuite/gdb.base/shr2.c | 10 +-
gdb/testsuite/gdb.base/sigall.c | 426 ---------------------
gdb/testsuite/gdb.base/sigaltstack.c | 2 +
gdb/testsuite/gdb.base/siginfo.c | 1 +
gdb/testsuite/gdb.base/signals.c | 6 -
gdb/testsuite/gdb.base/skip-solib-lib.c | 8 +-
gdb/testsuite/gdb.base/so-impl-ld.exp | 4 +-
gdb/testsuite/gdb.base/so-indr-cl.c | 8 -
gdb/testsuite/gdb.base/solib-weak.c | 2 +
gdb/testsuite/gdb.base/solib1.c | 16 +-
gdb/testsuite/gdb.base/solib2.c | 5 -
gdb/testsuite/gdb.base/structs.c | 91 +----
gdb/testsuite/gdb.base/sum.c | 7 +-
gdb/testsuite/gdb.base/testenv.c | 1 +
gdb/testsuite/gdb.base/vforked-prog.c | 4 -
gdb/testsuite/gdb.base/watchpoint.c | 4 -
gdb/testsuite/gdb.base/weaklib1.c | 2 +
gdb/testsuite/gdb.base/weaklib2.c | 2 +
.../gdb.mi/mi-condbreak-call-thr-state-mt.c | 2 +
gdb/testsuite/gdb.mi/mi-console.c | 4 +-
gdb/testsuite/gdb.mi/mi-console.exp | 3 +-
gdb/testsuite/gdb.mi/mi-exit-code.c | 2 +
gdb/testsuite/gdb.mi/mi-stack.c | 9 +-
gdb/testsuite/gdb.mi/mi-syn-frame.c | 2 +
gdb/testsuite/gdb.mi/until.c | 2 +
gdb/testsuite/gdb.mi/watch-nonstop.c | 2 +
gdb/testsuite/gdb.python/py-events.c | 2 +
gdb/testsuite/gdb.python/py-finish-breakpoint.c | 1 +
gdb/testsuite/gdb.reverse/shr2.c | 8 -
gdb/testsuite/gdb.reverse/until-reverse.c | 29 --
gdb/testsuite/gdb.reverse/ur1.c | 7 -
gdb/testsuite/gdb.reverse/watch-reverse.c | 4 -
99 files changed, 319 insertions(+), 2144 deletions(-)
--
1.8.4.2
next reply other threads:[~2014-10-29 15:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 15:51 Andreas Arnez [this message]
2014-10-29 16:00 ` [PATCH 01/16] Eliminate literal line numbers in so-impl-ld.exp Andreas Arnez
2014-10-29 16:22 ` Sergio Durigan Junior
2014-10-29 18:26 ` Andreas Arnez
2014-10-29 22:11 ` Sergio Durigan Junior
2014-10-31 20:59 ` Sergio Durigan Junior
2014-11-13 13:15 ` Yao Qi
2014-10-29 16:01 ` [PATCH 05/16] Eliminate literal line numbers in ending-run.exp Andreas Arnez
2014-11-13 13:44 ` Yao Qi
2014-10-29 16:01 ` [PATCH 03/16] Eliminate literal line numbers in call-ar-st.exp Andreas Arnez
2014-11-13 13:33 ` Yao Qi
2014-10-29 16:01 ` [PATCH 04/16] Eliminate literal line numbers in call-rt-st.exp Andreas Arnez
2014-11-13 13:36 ` Yao Qi
2014-10-29 16:01 ` [PATCH 02/16] Eliminate literal line numbers in dbx.exp Andreas Arnez
2014-11-13 13:18 ` Yao Qi
2014-11-13 14:16 ` Andreas Arnez
2014-11-14 0:26 ` Yao Qi
2014-10-29 16:02 ` [PATCH 06/16] Eliminate literal line numbers in foll-exec.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 09/16] Eliminate literal line numbers in mi-console.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 08/16] Eliminate literal line numbers in shlib-call.exp Andreas Arnez
2014-10-29 16:02 ` [PATCH 07/16] Eliminate literal line numbers in jump.exp Andreas Arnez
2014-10-29 16:03 ` [PATCH 11/16] Drop non-prototype C function header variants: solib1.c Andreas Arnez
2014-10-29 16:03 ` [PATCH 12/16] Drop non-prototype C function header variants: 'break' test case Andreas Arnez
2014-10-29 16:03 ` [PATCH 10/16] 'callfuncs' test case: Fix typo in prototyped version Andreas Arnez
2014-10-29 16:04 ` [PATCH 15/16] GDB testsuite: drop non-prototype C function header variants Andreas Arnez
2014-10-29 16:04 ` [PATCH 14/16] Drop non-prototype C function header variants: 'sepdebug' test case Andreas Arnez
2014-10-29 16:04 ` [PATCH 13/16] Drop non-prototype C function header variants: 'list' " Andreas Arnez
2014-11-12 12:33 ` Pedro Alves
2014-11-12 15:05 ` Andreas Arnez
2014-11-12 15:18 ` Pedro Alves
2014-10-29 16:04 ` [PATCH 16/16] GDB testsuite: Fix warnings with -std=gnu11 Andreas Arnez
2014-11-13 14:06 ` [PATCH 00/16] GDB testsuite cleanup, fix " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox