From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 742 invoked by alias); 29 Oct 2014 15:51:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 729 invoked by uid 89); 29 Oct 2014 15:51:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 29 Oct 2014 15:51:07 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Oct 2014 15:51:03 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 29 Oct 2014 15:51:01 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 581FA219005C for ; Wed, 29 Oct 2014 15:50:36 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9TFp0ct45809708 for ; Wed, 29 Oct 2014 15:51:00 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9TFp0kS030581 for ; Wed, 29 Oct 2014 09:51:00 -0600 Received: from br87z6lw.boeblingen.de.ibm.com (dyn-9-152-212-196.boeblingen.de.ibm.com [9.152.212.196]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s9TFp0ie030564 for ; Wed, 29 Oct 2014 09:51:00 -0600 From: Andreas Arnez To: gdb-patches@sourceware.org Subject: [PATCH 00/16] GDB testsuite cleanup, fix warnings with -std=gnu11 Date: Wed, 29 Oct 2014 15:51:00 -0000 Message-Id: <1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14102915-0009-0000-0000-000001BCDDBE X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00802.txt.bz2 This patch set was triggered by the fact that upstream GCC has changed the default C language dialect to 'gnu11': https://gcc.gnu.org/ml/gcc/2014-10/msg00053.html While the GDB source code doesn't seem to have any issues with that, the test suite has, because it contains many functions without return types and lots of implicit function declarations. But while fixing these, I noticed that many test cases still rely on literal line numbers and thus would fail after fixing the warnings. Thus the first part of the patch set deals with eliminating literal line numbers from various test cases. Another observation is that many existing C source files in the test suite contain code like this: #ifdef PROTOTYPES #else #endif And that the prototyped variant would sometimes *fix* the warning. However, the PROTOTYPES macro is never defined, hence the old-style version is always used. Thus the second part of the patch series performs some clean-up in this area by consequently migrating to the prototyped variants and getting rid of such preprocessor conditionals. The final part of the series then fixes the remaining warnings. Andreas Arnez (16): Eliminate literal line numbers in so-impl-ld.exp Eliminate literal line numbers in dbx.exp Eliminate literal line numbers in call-ar-st.exp Eliminate literal line numbers in call-rt-st.exp Eliminate literal line numbers in ending-run.exp Eliminate literal line numbers in foll-exec.exp Eliminate literal line numbers in jump.exp Eliminate literal line numbers in shlib-call.exp Eliminate literal line numbers in mi-console.exp 'callfuncs' test case: Fix typo in prototyped version Drop non-prototype C function header variants: solib1.c Drop non-prototype C function header variants: 'break' test case Drop non-prototype C function header variants: 'list' test case Drop non-prototype C function header variants: 'sepdebug' test case GDB testsuite: drop non-prototype C function header variants GDB testsuite: Fix warnings with -std=gnu11 gdb/testsuite/gdb.ada/cond_lang/foo.c | 2 +- gdb/testsuite/gdb.base/advance.c | 10 +- gdb/testsuite/gdb.base/annota1.c | 13 - gdb/testsuite/gdb.base/annota3.c | 13 - gdb/testsuite/gdb.base/async-shell.c | 2 + gdb/testsuite/gdb.base/async.c | 28 +- gdb/testsuite/gdb.base/attach-pie-misread.c | 1 + gdb/testsuite/gdb.base/attach-twice.c | 1 + gdb/testsuite/gdb.base/average.c | 17 +- gdb/testsuite/gdb.base/break-interp-lib.c | 1 + gdb/testsuite/gdb.base/break.c | 29 -- gdb/testsuite/gdb.base/break.exp | 29 +- gdb/testsuite/gdb.base/break1.c | 7 - gdb/testsuite/gdb.base/call-ar-st.c | 308 +-------------- gdb/testsuite/gdb.base/call-ar-st.exp | 165 ++++---- gdb/testsuite/gdb.base/call-rt-st.c | 157 +------- gdb/testsuite/gdb.base/call-rt-st.exp | 11 +- gdb/testsuite/gdb.base/call-sc.c | 7 +- gdb/testsuite/gdb.base/call-strs.c | 22 -- gdb/testsuite/gdb.base/callfuncs.c | 131 +------ gdb/testsuite/gdb.base/catch-signal-fork.c | 2 + gdb/testsuite/gdb.base/checkpoint.c | 7 +- gdb/testsuite/gdb.base/code_elim2.c | 12 +- gdb/testsuite/gdb.base/coremaker.c | 1 + gdb/testsuite/gdb.base/dbx.exp | 16 +- gdb/testsuite/gdb.base/dprintf-non-stop.c | 2 + gdb/testsuite/gdb.base/dump.c | 2 + gdb/testsuite/gdb.base/ending-run.c | 9 +- gdb/testsuite/gdb.base/ending-run.exp | 38 +- gdb/testsuite/gdb.base/execd-prog.c | 8 +- gdb/testsuite/gdb.base/exprs.c | 7 - gdb/testsuite/gdb.base/fileio.c | 1 + gdb/testsuite/gdb.base/foll-exec.c | 8 +- gdb/testsuite/gdb.base/foll-exec.exp | 37 +- gdb/testsuite/gdb.base/foll-fork.c | 9 - gdb/testsuite/gdb.base/foll-vfork.c | 4 - gdb/testsuite/gdb.base/funcargs.c | 334 ---------------- gdb/testsuite/gdb.base/gcore.c | 6 +- gdb/testsuite/gdb.base/global-var-nested-by-dso.c | 3 + gdb/testsuite/gdb.base/huge.c | 1 + gdb/testsuite/gdb.base/inferior-died.c | 1 + gdb/testsuite/gdb.base/info-os.c | 1 + gdb/testsuite/gdb.base/jump.c | 11 +- gdb/testsuite/gdb.base/jump.exp | 29 +- gdb/testsuite/gdb.base/langs0.c | 6 - gdb/testsuite/gdb.base/langs1.c | 8 - gdb/testsuite/gdb.base/langs2.c | 17 - gdb/testsuite/gdb.base/list0.h | 8 +- gdb/testsuite/gdb.base/list1.c | 20 +- gdb/testsuite/gdb.base/mips_pro.c | 25 -- gdb/testsuite/gdb.base/multi-forks.c | 3 +- gdb/testsuite/gdb.base/nodebug.c | 32 -- gdb/testsuite/gdb.base/opaque0.c | 2 - gdb/testsuite/gdb.base/opaque1.c | 5 - gdb/testsuite/gdb.base/pr10179-a.c | 1 + gdb/testsuite/gdb.base/recurse.c | 6 - gdb/testsuite/gdb.base/run.c | 11 - gdb/testsuite/gdb.base/savedregs.c | 2 + gdb/testsuite/gdb.base/scope0.c | 29 -- gdb/testsuite/gdb.base/scope1.c | 4 - gdb/testsuite/gdb.base/sepdebug.c | 29 -- gdb/testsuite/gdb.base/sepdebug.exp | 30 +- gdb/testsuite/gdb.base/setshow.c | 7 - gdb/testsuite/gdb.base/setvar.c | 7 - gdb/testsuite/gdb.base/shlib-call.exp | 2 +- gdb/testsuite/gdb.base/shmain.c | 10 - gdb/testsuite/gdb.base/shr1.c | 20 - gdb/testsuite/gdb.base/shr2.c | 10 +- gdb/testsuite/gdb.base/sigall.c | 426 --------------------- gdb/testsuite/gdb.base/sigaltstack.c | 2 + gdb/testsuite/gdb.base/siginfo.c | 1 + gdb/testsuite/gdb.base/signals.c | 6 - gdb/testsuite/gdb.base/skip-solib-lib.c | 8 +- gdb/testsuite/gdb.base/so-impl-ld.exp | 4 +- gdb/testsuite/gdb.base/so-indr-cl.c | 8 - gdb/testsuite/gdb.base/solib-weak.c | 2 + gdb/testsuite/gdb.base/solib1.c | 16 +- gdb/testsuite/gdb.base/solib2.c | 5 - gdb/testsuite/gdb.base/structs.c | 91 +---- gdb/testsuite/gdb.base/sum.c | 7 +- gdb/testsuite/gdb.base/testenv.c | 1 + gdb/testsuite/gdb.base/vforked-prog.c | 4 - gdb/testsuite/gdb.base/watchpoint.c | 4 - gdb/testsuite/gdb.base/weaklib1.c | 2 + gdb/testsuite/gdb.base/weaklib2.c | 2 + .../gdb.mi/mi-condbreak-call-thr-state-mt.c | 2 + gdb/testsuite/gdb.mi/mi-console.c | 4 +- gdb/testsuite/gdb.mi/mi-console.exp | 3 +- gdb/testsuite/gdb.mi/mi-exit-code.c | 2 + gdb/testsuite/gdb.mi/mi-stack.c | 9 +- gdb/testsuite/gdb.mi/mi-syn-frame.c | 2 + gdb/testsuite/gdb.mi/until.c | 2 + gdb/testsuite/gdb.mi/watch-nonstop.c | 2 + gdb/testsuite/gdb.python/py-events.c | 2 + gdb/testsuite/gdb.python/py-finish-breakpoint.c | 1 + gdb/testsuite/gdb.reverse/shr2.c | 8 - gdb/testsuite/gdb.reverse/until-reverse.c | 29 -- gdb/testsuite/gdb.reverse/ur1.c | 7 - gdb/testsuite/gdb.reverse/watch-reverse.c | 4 - 99 files changed, 319 insertions(+), 2144 deletions(-) -- 1.8.4.2