From: Tom Tromey <tom@tromey.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: fix is_amd64_regs_target
Date: Thu, 27 Sep 2018 21:10:00 -0000 [thread overview]
Message-ID: <8736tuodf9.fsf@tromey.com> (raw)
In-Reply-To: <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Thu, 27 Sep 2018 09:42:29 +0200")
>>>>> "Markus" == Markus Metzger <markus.t.metzger@intel.com> writes:
Markus> testsuite/
Markus> * lib/gdb.exp (is_amd64_regs_target): Change assembly to C inline
Markus> assembly.
Markus> - set list {}
Markus> - foreach reg \
Markus> - {rax rbx rcx rdx rsi rdi rbp rsp r8 r9 r10 r11 r12 r13 r14 r15} {
Markus> - lappend list "\tincq %$reg"
Markus> - }
Markus> + return [gdb_can_simple_compile is_amd64_regs_target {
Markus> + int main (void) {
Markus> + asm ("incq %rax");
Markus> + asm ("incq %r15");
I suppose reducing the number of registers tested doesn't materially
affect the test.
Assuming that's the case, this is ok. Thank you.
Tom
next prev parent reply other threads:[~2018-09-27 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:42 [PATCH] btrace: check for indirect jump return in _Unwind_RaiseException Markus Metzger
2018-09-27 7:44 ` [PATCH] testsuite: fix is_amd64_regs_target Markus Metzger
2018-09-27 21:10 ` Tom Tromey [this message]
2018-09-28 7:07 ` Metzger, Markus T
2018-09-28 17:34 ` Tom Tromey
[not found] ` <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com>
2018-09-29 18:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736tuodf9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox