From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] testsuite: fix is_amd64_regs_target
Date: Thu, 27 Sep 2018 07:44:00 -0000 [thread overview]
Message-ID: <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> (raw)
In-Reply-To: <1538034149-12136-1-git-send-email-markus.t.metzger@intel.com>
Commit
c221b2f Testsuite: Add gdb_can_simple_compile
changed the source file name extension of the test program from .s to .c
resulting in compile fails. This, in turn, causes is_amd64_regs_target
checks to fail. In gdb.btrace/tailcall.exp and others, this causes the
wrong source file to be picked and the test to fail on 64-bit targets.
Change the test source from an assembly program to a C program using
inline assembly.
There is a similar case for is_aarch32_target that I have not touched as I
would not be able to test my changes.
2018-09-27 Markus Metzger <markus.t.metzger@intel.com>
testsuite/
* lib/gdb.exp (is_amd64_regs_target): Change assembly to C inline
assembly.
---
gdb/testsuite/lib/gdb.exp | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f32abfedd52..1eea92298c4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2467,13 +2467,14 @@ gdb_caching_proc is_amd64_regs_target {
return 0
}
- set list {}
- foreach reg \
- {rax rbx rcx rdx rsi rdi rbp rsp r8 r9 r10 r11 r12 r13 r14 r15} {
- lappend list "\tincq %$reg"
- }
+ return [gdb_can_simple_compile is_amd64_regs_target {
+ int main (void) {
+ asm ("incq %rax");
+ asm ("incq %r15");
- return [gdb_can_simple_compile is_amd64_regs_target [join $list \n]]
+ return 0;
+ }
+ }]
}
# Return 1 if this target is an x86 or x86-64 with -m32.
--
2.17.1
next prev parent reply other threads:[~2018-09-27 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:42 [PATCH] btrace: check for indirect jump return in _Unwind_RaiseException Markus Metzger
2018-09-27 7:44 ` Markus Metzger [this message]
2018-09-27 21:10 ` [PATCH] testsuite: fix is_amd64_regs_target Tom Tromey
2018-09-28 7:07 ` Metzger, Markus T
2018-09-28 17:34 ` Tom Tromey
[not found] ` <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com>
2018-09-29 18:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538034149-12136-2-git-send-email-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox