From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>,
Tom Tromey <tom@tromey.com>,
"Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] testsuite: fix is_amd64_regs_target
Date: Sat, 29 Sep 2018 18:09:00 -0000 [thread overview]
Message-ID: <2415b90d-4b2c-7058-e07d-d8cba49e1687@redhat.com> (raw)
In-Reply-To: <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com>
On 09/28/2018 09:27 PM, Simon Marchi wrote:
> Maybe I'm missing something obvious, but could one of you explain to me
> the comment of that proc, which is
>
> # Return 1 if target has x86_64 registers - either amd64 or x32.
> # x32 target identifies as x86_64-*-linux*, therefore it cannot be determined
> # just from the target string.
>
> If I understand correctly, is_amd64_regs_target should return 1 when using the
> x32 abi, as well as when using the standard amd64 abi. The comment says an x32
> target has an x86_64-* triplet... so can't we just check the triplet, and return
> 1 if it's x86-64-*?
No, because toolchains configured with i686-* triplets can also be
used in combination with -mx32/-m64.
Same for is_64_target, is_lp64_target, etc.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-09-29 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:42 [PATCH] btrace: check for indirect jump return in _Unwind_RaiseException Markus Metzger
2018-09-27 7:44 ` [PATCH] testsuite: fix is_amd64_regs_target Markus Metzger
2018-09-27 21:10 ` Tom Tromey
2018-09-28 7:07 ` Metzger, Markus T
2018-09-28 17:34 ` Tom Tromey
[not found] ` <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com>
2018-09-29 18:09 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2415b90d-4b2c-7058-e07d-d8cba49e1687@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox