From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125060 invoked by alias); 29 Sep 2018 18:09:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125050 invoked by uid 89); 29 Sep 2018 18:09:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*Ad:U*palves, H*f:sk:87wor5m X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 29 Sep 2018 18:09:11 +0000 Received: by mail-wm1-f67.google.com with SMTP id b19-v6so5029906wme.3 for ; Sat, 29 Sep 2018 11:09:11 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id 144-v6sm5300526wma.19.2018.09.29.11.09.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Sep 2018 11:09:08 -0700 (PDT) Subject: Re: [PATCH] testsuite: fix is_amd64_regs_target To: Simon Marchi , Tom Tromey , "Metzger, Markus T" References: <1538034149-12136-1-git-send-email-markus.t.metzger@intel.com> <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> <8736tuodf9.fsf@tromey.com> <87wor5mtca.fsf@tromey.com> <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <2415b90d-4b2c-7058-e07d-d8cba49e1687@redhat.com> Date: Sat, 29 Sep 2018 18:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8a5ded70-add4-df1d-5f7f-6f7682d58059@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00935.txt.bz2 On 09/28/2018 09:27 PM, Simon Marchi wrote: > Maybe I'm missing something obvious, but could one of you explain to me > the comment of that proc, which is > > # Return 1 if target has x86_64 registers - either amd64 or x32. > # x32 target identifies as x86_64-*-linux*, therefore it cannot be determined > # just from the target string. > > If I understand correctly, is_amd64_regs_target should return 1 when using the > x32 abi, as well as when using the standard amd64 abi. The comment says an x32 > target has an x86_64-* triplet... so can't we just check the triplet, and return > 1 if it's x86-64-*? No, because toolchains configured with i686-* triplets can also be used in combination with -mx32/-m64. Same for is_64_target, is_lp64_target, etc. Thanks, Pedro Alves