From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107541 invoked by alias); 27 Sep 2018 21:10:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107525 invoked by uid 89); 27 Sep 2018 21:10:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.124.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Sep 2018 21:10:39 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 3A5C9400E4CF2 for ; Thu, 27 Sep 2018 15:16:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5dXPgW2qL8YaU5dXsgzuL1; Thu, 27 Sep 2018 16:10:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U0pNRIn7BxYL3oW6jMy0z+gSVlWu9OWUNf053FZGSXk=; b=nOQptxXKg3I1V4hjPLi+ILLR9U ib1lxmJwkClsAh6rBD6QiZuSiuUFKvB+lZPuhGiacdkgrh4dJshCCk17iujp39QybOvJy/82+2U7x CIDQganpPwnmRNN+3yDEsxnGB; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:37418 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g5dXP-0047LS-54; Thu, 27 Sep 2018 16:09:31 -0500 From: Tom Tromey To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: fix is_amd64_regs_target References: <1538034149-12136-1-git-send-email-markus.t.metzger@intel.com> <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> Date: Thu, 27 Sep 2018 21:10:00 -0000 In-Reply-To: <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Thu, 27 Sep 2018 09:42:29 +0200") Message-ID: <8736tuodf9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00883.txt.bz2 >>>>> "Markus" == Markus Metzger writes: Markus> testsuite/ Markus> * lib/gdb.exp (is_amd64_regs_target): Change assembly to C inline Markus> assembly. Markus> - set list {} Markus> - foreach reg \ Markus> - {rax rbx rcx rdx rsi rdi rbp rsp r8 r9 r10 r11 r12 r13 r14 r15} { Markus> - lappend list "\tincq %$reg" Markus> - } Markus> + return [gdb_can_simple_compile is_amd64_regs_target { Markus> + int main (void) { Markus> + asm ("incq %rax"); Markus> + asm ("incq %r15"); I suppose reducing the number of registers tested doesn't materially affect the test. Assuming that's the case, this is ok. Thank you. Tom