Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add method/format information to =record-started
Date: Tue, 05 Jul 2016 13:51:00 -0000	[thread overview]
Message-ID: <86wpl0xkg4.fsf@gmail.com> (raw)
In-Reply-To: <20160603155220.22286-1-simon.marchi@ericsson.com> (Simon	Marchi's message of "Fri, 3 Jun 2016 11:52:20 -0400")

Simon Marchi <simon.marchi@ericsson.com> writes:

> gdb/testsuite/ChangeLog:
>
> 	* gdb.mi/mi-record-changed.exp: Adjust =record-started output
> 	matching.

We need to update gdb.mi/mi-reverse.exp too.  Patch below does it.
Patch is pushed in.

-- 
Yao (齐尧)
From 647c264cb2c60c90ee2d09edb6bd001ff357306d Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Tue, 5 Jul 2016 14:46:21 +0100
Subject: [PATCH] Fix fail in gdb.mi/mi-reverse.exp

Commit 38b022b4452f996fb5a8598f80d850b594621bcf adds "method" and
"format" fields in =record-started, but doesn't update test case
gdb.mi/mi-reverse.exp, so it causes the fail like this,

PASS: gdb.mi/mi-reverse.exp: mi runto main
Expecting: ^(-interpreter-exec console record[^M
]+)?(=record-started,thread-group="i1"^M
\^done[^M
]+[(]gdb[)] ^M
[ ]*)
-interpreter-exec console record^M
=record-started,thread-group="i1",method="full"^M
^done^M
(gdb) ^M
FAIL: gdb.mi/mi-reverse.exp: Turn on process record

and regression was found by buildbot too
https://sourceware.org/ml/gdb-testers/2016-q2/msg04492.html

gdb/testsuite:

2016-07-05  Yao Qi  <yao.qi@linaro.org>

	* gdb.mi/mi-reverse.exp: Match =record-started output.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index bcbffaa..be0cf9d 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2016-07-05  Yao Qi  <yao.qi@linaro.org>
+
+	* gdb.mi/mi-reverse.exp: Match =record-started output.
+
 2016-07-01  Pedro Alves  <palves@redhat.com>
 
 	* gdb.base/jit-reader.exp (info_registers_current_frame): New
diff --git a/gdb/testsuite/gdb.mi/mi-reverse.exp b/gdb/testsuite/gdb.mi/mi-reverse.exp
index d8f3844..5afeece 100644
--- a/gdb/testsuite/gdb.mi/mi-reverse.exp
+++ b/gdb/testsuite/gdb.mi/mi-reverse.exp
@@ -51,7 +51,7 @@ mi_run_to_main
 if [supports_process_record] {
     # Activate process record/replay
     if [mi_gdb_test "-interpreter-exec console record" \
-	    "=record-started,thread-group=\"i1\"\r\n\\^done" \
+	    "=record-started,thread-group=\"i1\",method=\"full\"\r\n\\^done" \
 	    "Turn on process record"] {
 	warning "Fail to activate process record/replay, tests in this group will not be performed.\n"
 	return -1


  parent reply	other threads:[~2016-07-05 13:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 15:52 Simon Marchi
2016-06-03 17:03 ` Simon Marchi
2016-06-06  6:38 ` Metzger, Markus T
2016-06-06 13:03   ` Yao Qi
2016-06-06 13:24     ` Simon Marchi
2016-06-07  9:32       ` Yao Qi
2016-06-07 12:53         ` Simon Marchi
2016-06-07 15:38           ` Yao Qi
2016-06-07 15:48             ` Simon Marchi
2016-06-06 13:07   ` Simon Marchi
2016-06-06 13:20     ` Metzger, Markus T
2016-06-06 13:39       ` Simon Marchi
2016-06-06 13:44         ` Metzger, Markus T
2016-06-06 13:49           ` Simon Marchi
2016-06-06 14:02             ` Metzger, Markus T
2016-06-06 14:28               ` Simon Marchi
2016-06-06 14:33                 ` Metzger, Markus T
2016-06-06 15:13             ` Eli Zaretskii
2016-06-06 21:12               ` Simon Marchi
2016-07-05 13:51 ` Yao Qi [this message]
2016-07-05 13:52   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wpl0xkg4.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox