Re: [PATCH] Add method/format information to =record-started

[Simon Marchi <simon.marchi@ericsson.com>]

On 16-06-07 11:38 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>>>>   else
>>>>     fprintf_unfiltered (mi->event_channel,
>>>> 			"record-stopped,thread-group=\"i%d\"", inferior->num);
>>
>> I suppose here too?
> 
> Yes, I think so.

Ok, I pushed this patch to fix it:


From 1aec0b6ad6eae1fa97bb1a4a47959ff204aa15a2 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Tue, 7 Jun 2016 10:02:42 -0400
Subject: [PATCH] mi/mi-interp.c: Add missing braces

gdb/ChangeLog:

	* mi/mi-interp.c (mi_record_changed): Add missing braces.
---
 gdb/ChangeLog      |  4 ++++
 gdb/mi/mi-interp.c | 26 ++++++++++++++++----------
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bd2d5d2..9c09269 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-06-07  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* mi/mi-interp.c (mi_record_changed): Add missing braces.
+
 2016-06-07  Bernhard Heckel  <bernhard.heckel@intel.com>

 	* findvar.c (follow_static_link): Check for valid pointer.
diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
index 8ce816c..3bbdb1f 100644
--- a/gdb/mi/mi-interp.c
+++ b/gdb/mi/mi-interp.c
@@ -412,19 +412,25 @@ mi_record_changed (struct inferior *inferior, int started, const char *method,
   if (started)
     {
       if (format != NULL)
-	fprintf_unfiltered (
-	  mi->event_channel,
-	  "record-started,thread-group=\"i%d\",method=\"%s\",format=\"%s\"",
-	  inferior->num, method, format);
+	{
+	  fprintf_unfiltered (
+	    mi->event_channel,
+	    "record-started,thread-group=\"i%d\",method=\"%s\",format=\"%s\"",
+	    inferior->num, method, format);
+	}
       else
-	fprintf_unfiltered (
-	  mi->event_channel,
-	  "record-started,thread-group=\"i%d\",method=\"%s\"",
-	  inferior->num, method);
+	{
+	  fprintf_unfiltered (
+	    mi->event_channel,
+	    "record-started,thread-group=\"i%d\",method=\"%s\"",
+	    inferior->num, method);
+	}
     }
   else
-    fprintf_unfiltered (mi->event_channel,
-			"record-stopped,thread-group=\"i%d\"", inferior->num);
+    {
+      fprintf_unfiltered (mi->event_channel,
+			  "record-stopped,thread-group=\"i%d\"", inferior->num);
+    }


   gdb_flush (mi->event_channel);
-- 
2.8.3