From: Simon Marchi <simon.marchi@ericsson.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add method/format information to =record-started
Date: Mon, 06 Jun 2016 13:39:00 -0000 [thread overview]
Message-ID: <57557D26.2080009@ericsson.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B23332EB299@IRSMSX104.ger.corp.intel.com>
On 16-06-06 09:20 AM, Metzger, Markus T wrote:
> Looks good except that BTRACE_FORMAT_NONE is not handled in the switch.
>
> We could leave it as a bad format string to be detected by the MI consumer. This would
> leave the short and long versions of btrace_format_string symmetric.
What do you mean by MI consumer? The MI front-end (e.g. Eclipse), or the MI interpreter
code in gdb (mi-interp.c) ?
My thought was that not handling it in the switch (and let gdb implode) would help catch
a bug earlier, compared to emitting some invalid string. But I don't really mind. I can
add
case BTRACE_FORMAT_NONE:
return "unknown";
next prev parent reply other threads:[~2016-06-06 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 15:52 Simon Marchi
2016-06-03 17:03 ` Simon Marchi
2016-06-06 6:38 ` Metzger, Markus T
2016-06-06 13:03 ` Yao Qi
2016-06-06 13:24 ` Simon Marchi
2016-06-07 9:32 ` Yao Qi
2016-06-07 12:53 ` Simon Marchi
2016-06-07 15:38 ` Yao Qi
2016-06-07 15:48 ` Simon Marchi
2016-06-06 13:07 ` Simon Marchi
2016-06-06 13:20 ` Metzger, Markus T
2016-06-06 13:39 ` Simon Marchi [this message]
2016-06-06 13:44 ` Metzger, Markus T
2016-06-06 13:49 ` Simon Marchi
2016-06-06 14:02 ` Metzger, Markus T
2016-06-06 14:28 ` Simon Marchi
2016-06-06 14:33 ` Metzger, Markus T
2016-06-06 15:13 ` Eli Zaretskii
2016-06-06 21:12 ` Simon Marchi
2016-07-05 13:51 ` Yao Qi
2016-07-05 13:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57557D26.2080009@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox