From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45051 invoked by alias); 6 Jun 2016 13:39:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44715 invoked by uid 89); 6 Jun 2016 13:39:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Jun 2016 13:39:53 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 11.C5.03614.EEC75575; Mon, 6 Jun 2016 15:38:54 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.294.0; Mon, 6 Jun 2016 09:39:50 -0400 Subject: Re: [PATCH] Add method/format information to =record-started To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <20160603155220.22286-1-simon.marchi@ericsson.com> <57557571.7040200@ericsson.com> From: Simon Marchi Message-ID: <57557D26.2080009@ericsson.com> Date: Mon, 06 Jun 2016 13:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00089.txt.bz2 On 16-06-06 09:20 AM, Metzger, Markus T wrote: > Looks good except that BTRACE_FORMAT_NONE is not handled in the switch. > > We could leave it as a bad format string to be detected by the MI consumer. This would > leave the short and long versions of btrace_format_string symmetric. What do you mean by MI consumer? The MI front-end (e.g. Eclipse), or the MI interpreter code in gdb (mi-interp.c) ? My thought was that not handling it in the switch (and let gdb implode) would help catch a bug earlier, compared to emitting some invalid string. But I don't really mind. I can add case BTRACE_FORMAT_NONE: return "unknown";