Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: markus.t.metzger@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add method/format information to =record-started
Date: Mon, 06 Jun 2016 15:13:00 -0000	[thread overview]
Message-ID: <83d1nutknu.fsf@gnu.org> (raw)
In-Reply-To: <57557F4D.8020409@ericsson.com> (message from Simon Marchi on	Mon, 6 Jun 2016 09:49:01 -0400)

> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Mon, 6 Jun 2016 09:49:01 -0400
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index dce79a2..253c8e5 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -67,6 +67,11 @@ maint selftest
>    including JIT compiling fast tracepoint's conditional expression
>    bytecode into native code.
> 
> +* MI async record =record-started now includes the method and format used for
> +  recording.  For example:
> +
> +    =record-started,thread-group="i1",method="btrace",format="bts"
> +
>  *** Changes in GDB 7.11

This is OK.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 7e89003..f50582a 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -26423,12 +26423,17 @@ breakpoint commands; @xref{GDB/MI Breakpoint Commands}.  The
>  Note that if a breakpoint is emitted in the result record of a
>  command, then it will not also be emitted in an async record.
> 
> -@item =record-started,thread-group="@var{id}"
> +@item =record-started,thread-group="@var{id}",method="@var{method}"[,format="@var{format}"]
>  @itemx =record-stopped,thread-group="@var{id}"
>  Execution log recording was either started or stopped on an
>  inferior.  The @var{id} is the @value{GDBN} identifier of the thread
>  group corresponding to the affected inferior.
> 
> +The @var{method} field indicates the method used to record execution.  If the
> +method in use supports multiple recording formats, @var{format} will be present
> +and contain the currently used format.  See @xref{Process Record and Replay}
> +for existing method and format values.  ^^^

No need for "See" there, as @xref generates that automatically.  Or
use "See @ref".

OK for the documentation parts, with the above gotcha fixed.


  parent reply	other threads:[~2016-06-06 15:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 15:52 Simon Marchi
2016-06-03 17:03 ` Simon Marchi
2016-06-06  6:38 ` Metzger, Markus T
2016-06-06 13:03   ` Yao Qi
2016-06-06 13:24     ` Simon Marchi
2016-06-07  9:32       ` Yao Qi
2016-06-07 12:53         ` Simon Marchi
2016-06-07 15:38           ` Yao Qi
2016-06-07 15:48             ` Simon Marchi
2016-06-06 13:07   ` Simon Marchi
2016-06-06 13:20     ` Metzger, Markus T
2016-06-06 13:39       ` Simon Marchi
2016-06-06 13:44         ` Metzger, Markus T
2016-06-06 13:49           ` Simon Marchi
2016-06-06 14:02             ` Metzger, Markus T
2016-06-06 14:28               ` Simon Marchi
2016-06-06 14:33                 ` Metzger, Markus T
2016-06-06 15:13             ` Eli Zaretskii [this message]
2016-06-06 21:12               ` Simon Marchi
2016-07-05 13:51 ` Yao Qi
2016-07-05 13:52   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1nutknu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox