From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99035 invoked by alias); 6 Jun 2016 15:13:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99019 invoked by uid 89); 6 Jun 2016 15:13:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1784, HX-HELO:eggs.gnu.org, Hx-spam-relays-external:208.118.235.92, H*RU:208.118.235.92 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Jun 2016 15:13:16 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9wDG-0006J7-Io for gdb-patches@sourceware.org; Mon, 06 Jun 2016 11:13:13 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9wDG-0006Iq-Ew; Mon, 06 Jun 2016 11:13:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4052 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9wDD-0006K5-7T; Mon, 06 Jun 2016 11:13:07 -0400 Date: Mon, 06 Jun 2016 15:13:00 -0000 Message-Id: <83d1nutknu.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: markus.t.metzger@intel.com, gdb-patches@sourceware.org In-reply-to: <57557F4D.8020409@ericsson.com> (message from Simon Marchi on Mon, 6 Jun 2016 09:49:01 -0400) Subject: Re: [PATCH] Add method/format information to =record-started Reply-to: Eli Zaretskii References: <20160603155220.22286-1-simon.marchi@ericsson.com> <57557571.7040200@ericsson.com> <57557D26.2080009@ericsson.com> <57557F4D.8020409@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00100.txt.bz2 > From: Simon Marchi > Date: Mon, 6 Jun 2016 09:49:01 -0400 > > diff --git a/gdb/NEWS b/gdb/NEWS > index dce79a2..253c8e5 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -67,6 +67,11 @@ maint selftest > including JIT compiling fast tracepoint's conditional expression > bytecode into native code. > > +* MI async record =record-started now includes the method and format used for > + recording. For example: > + > + =record-started,thread-group="i1",method="btrace",format="bts" > + > *** Changes in GDB 7.11 This is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 7e89003..f50582a 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -26423,12 +26423,17 @@ breakpoint commands; @xref{GDB/MI Breakpoint Commands}. The > Note that if a breakpoint is emitted in the result record of a > command, then it will not also be emitted in an async record. > > -@item =record-started,thread-group="@var{id}" > +@item =record-started,thread-group="@var{id}",method="@var{method}"[,format="@var{format}"] > @itemx =record-stopped,thread-group="@var{id}" > Execution log recording was either started or stopped on an > inferior. The @var{id} is the @value{GDBN} identifier of the thread > group corresponding to the affected inferior. > > +The @var{method} field indicates the method used to record execution. If the > +method in use supports multiple recording formats, @var{format} will be present > +and contain the currently used format. See @xref{Process Record and Replay} > +for existing method and format values. ^^^ No need for "See" there, as @xref generates that automatically. Or use "See @ref". OK for the documentation parts, with the above gotcha fixed.