From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120564 invoked by alias); 5 Jul 2016 13:51:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120555 invoked by uid 89); 5 Jul 2016 13:51:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=expecting, activate, Activate, Turn X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 05 Jul 2016 13:51:03 +0000 Received: by mail-pf0-f195.google.com with SMTP id c74so19188023pfb.0 for ; Tue, 05 Jul 2016 06:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ko/0LpjZ94+b/zY/mTCstt2lnZfNdo829jspE2ZwdMw=; b=ZsqpWKwn8qTmSG/lcx5HSrSr5ltkDvQQorSWJoZ0qq/IPSxoEh55mLdDjRK/rq6ly0 s17VGU0VgayFJaGf9vp37/pWw/yOtqs90ynrXra6UNj+vyWwlxuAEiD7kxvzwYO/ZNXr pCnAWpAEQ70RgW8teNqj/q5lmve9z7Vj544U9Dt4mjh+6++GkPKmiRTE5p5Shi5MMXsP D0khua14gUoUxBOcuIUSrK0chFwFDndVYrwLOwRz4u/hLlaql9Jla9oSHGymTIIJBg4X Ge1wY4Buut2Zu1wuLwi4DCBzEbQVAjknnfGd8QZ3f7cDOV/SKjlDkvFHiSVH3dLBT5/z emug== X-Gm-Message-State: ALyK8tI7G1JNgsa2ZYpr//8yITR+IRsez4gwYWpQ1eNhhwG3U21WJhrLc9o32ovspqO9lg== X-Received: by 10.98.196.203 with SMTP id h72mr32022608pfk.54.1467726661488; Tue, 05 Jul 2016 06:51:01 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id b7sm2595343pat.27.2016.07.05.06.50.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 05 Jul 2016 06:51:00 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH] Add method/format information to =record-started References: <20160603155220.22286-1-simon.marchi@ericsson.com> Date: Tue, 05 Jul 2016 13:51:00 -0000 In-Reply-To: <20160603155220.22286-1-simon.marchi@ericsson.com> (Simon Marchi's message of "Fri, 3 Jun 2016 11:52:20 -0400") Message-ID: <86wpl0xkg4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00063.txt.bz2 Simon Marchi writes: > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-record-changed.exp: Adjust =3Drecord-started output > matching. We need to update gdb.mi/mi-reverse.exp too. Patch below does it. Patch is pushed in. --=20 Yao (=E9=BD=90=E5=B0=A7) =46rom 647c264cb2c60c90ee2d09edb6bd001ff357306d Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Tue, 5 Jul 2016 14:46:21 +0100 Subject: [PATCH] Fix fail in gdb.mi/mi-reverse.exp Commit 38b022b4452f996fb5a8598f80d850b594621bcf adds "method" and "format" fields in =3Drecord-started, but doesn't update test case gdb.mi/mi-reverse.exp, so it causes the fail like this, PASS: gdb.mi/mi-reverse.exp: mi runto main Expecting: ^(-interpreter-exec console record[^M ]+)?(=3Drecord-started,thread-group=3D"i1"^M \^done[^M ]+[(]gdb[)] ^M [ ]*) -interpreter-exec console record^M =3Drecord-started,thread-group=3D"i1",method=3D"full"^M ^done^M (gdb) ^M FAIL: gdb.mi/mi-reverse.exp: Turn on process record and regression was found by buildbot too https://sourceware.org/ml/gdb-testers/2016-q2/msg04492.html gdb/testsuite: 2016-07-05 Yao Qi * gdb.mi/mi-reverse.exp: Match =3Drecord-started output. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bcbffaa..be0cf9d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-07-05 Yao Qi + + * gdb.mi/mi-reverse.exp: Match =3Drecord-started output. + 2016-07-01 Pedro Alves =20 * gdb.base/jit-reader.exp (info_registers_current_frame): New diff --git a/gdb/testsuite/gdb.mi/mi-reverse.exp b/gdb/testsuite/gdb.mi/mi-= reverse.exp index d8f3844..5afeece 100644 --- a/gdb/testsuite/gdb.mi/mi-reverse.exp +++ b/gdb/testsuite/gdb.mi/mi-reverse.exp @@ -51,7 +51,7 @@ mi_run_to_main if [supports_process_record] { # Activate process record/replay if [mi_gdb_test "-interpreter-exec console record" \ - "=3Drecord-started,thread-group=3D\"i1\"\r\n\\^done" \ + "=3Drecord-started,thread-group=3D\"i1\",method=3D\"full\"\r\n\\^done= " \ "Turn on process record"] { warning "Fail to activate process record/replay, tests in this group will= not be performed.\n" return -1