* [PATCH] gdb/README: Document GNU Make requirement
@ 2026-03-05 18:29 Guinevere Larsen
2026-03-05 18:56 ` Eli Zaretskii
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Guinevere Larsen @ 2026-03-05 18:29 UTC (permalink / raw)
To: gdb-patches; +Cc: Guinevere Larsen
User la_mettrie on IRC mentioned that they were having difficulties
building GDB, and after some debugging, we figured out that they weren't
using GNU Make. This is in the final documentation, but considering that
it is not an obvious place to look, and the README mentions other build
requirements, so this seems like a pretty obvious oversight.
---
gdb/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/README b/gdb/README
index 492b0891668..09c88bcd19c 100644
--- a/gdb/README
+++ b/gdb/README
@@ -86,8 +86,8 @@ configure the build tree.)
C++17 compiler for your system, you may be able to download and install
the GNU CC compiler. It is available via anonymous FTP from the
directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO
-C standard library. The GDB remote server, GDBserver, builds with some
-non-ISO standard libraries - e.g. for Windows CE.
+C standard library and GNU Make. The GDB remote server, GDBserver,
+builds with some non-ISO standard libraries - e.g. for Windows CE.
GDB can optionally be built against various external libraries.
These dependencies are described below in the "`configure options"
base-commit: 7c5179caca8cbca0f2fdb64f0fe215cee803ccb3
prerequisite-patch-id: 47ca70553d73d20b7f4c648078529a2bb301eb64
--
2.53.0
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH] gdb/README: Document GNU Make requirement 2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen @ 2026-03-05 18:56 ` Eli Zaretskii 2026-03-05 19:03 ` Guinevere Larsen 2026-03-05 19:01 ` Andrew Pinski 2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen 2 siblings, 1 reply; 15+ messages in thread From: Eli Zaretskii @ 2026-03-05 18:56 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > From: Guinevere Larsen <guinevere@redhat.com> > Cc: Guinevere Larsen <guinevere@redhat.com> > Date: Thu, 5 Mar 2026 15:29:30 -0300 > > User la_mettrie on IRC mentioned that they were having difficulties > building GDB, and after some debugging, we figured out that they weren't > using GNU Make. This is in the final documentation, but considering that > it is not an obvious place to look, and the README mentions other build > requirements, so this seems like a pretty obvious oversight. > --- > gdb/README | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/README b/gdb/README > index 492b0891668..09c88bcd19c 100644 > --- a/gdb/README > +++ b/gdb/README > @@ -86,8 +86,8 @@ configure the build tree.) > C++17 compiler for your system, you may be able to download and install > the GNU CC compiler. It is available via anonymous FTP from the > directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO > -C standard library. The GDB remote server, GDBserver, builds with some > -non-ISO standard libraries - e.g. for Windows CE. > +C standard library and GNU Make. The GDB remote server, GDBserver, > +builds with some non-ISO standard libraries - e.g. for Windows CE. Thanks, but shouldn't this be much closer to the beginning of the file, like where the build commands are first shown? Mentioning that here, so close to the end of the installation overview, sounds too late. People might overlook it. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] gdb/README: Document GNU Make requirement 2026-03-05 18:56 ` Eli Zaretskii @ 2026-03-05 19:03 ` Guinevere Larsen 2026-03-06 7:11 ` Eli Zaretskii 0 siblings, 1 reply; 15+ messages in thread From: Guinevere Larsen @ 2026-03-05 19:03 UTC (permalink / raw) To: Eli Zaretskii; +Cc: gdb-patches On 3/5/26 3:56 PM, Eli Zaretskii wrote: >> From: Guinevere Larsen <guinevere@redhat.com> >> Cc: Guinevere Larsen <guinevere@redhat.com> >> Date: Thu, 5 Mar 2026 15:29:30 -0300 >> >> User la_mettrie on IRC mentioned that they were having difficulties >> building GDB, and after some debugging, we figured out that they weren't >> using GNU Make. This is in the final documentation, but considering that >> it is not an obvious place to look, and the README mentions other build >> requirements, so this seems like a pretty obvious oversight. >> --- >> gdb/README | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/README b/gdb/README >> index 492b0891668..09c88bcd19c 100644 >> --- a/gdb/README >> +++ b/gdb/README >> @@ -86,8 +86,8 @@ configure the build tree.) >> C++17 compiler for your system, you may be able to download and install >> the GNU CC compiler. It is available via anonymous FTP from the >> directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO >> -C standard library. The GDB remote server, GDBserver, builds with some >> -non-ISO standard libraries - e.g. for Windows CE. >> +C standard library and GNU Make. The GDB remote server, GDBserver, >> +builds with some non-ISO standard libraries - e.g. for Windows CE. > Thanks, but shouldn't this be much closer to the beginning of the > file, like where the build commands are first shown? Mentioning that > here, so close to the end of the installation overview, sounds too > late. People might overlook it. > That's a good point. I only put it here because it's where the other build requirements were located, but I guess the entire paragraph should be moved up. I will do that for v2, but while I'm at it, should we really be teaching the user how to find a c++17 compiler? I think we should remove the instructions on downloading GCC from the ftp directory, and shorten the entire paragraph a bit, what do you think? -- Cheers, Guinevere Larsen It/she ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] gdb/README: Document GNU Make requirement 2026-03-05 19:03 ` Guinevere Larsen @ 2026-03-06 7:11 ` Eli Zaretskii 0 siblings, 0 replies; 15+ messages in thread From: Eli Zaretskii @ 2026-03-06 7:11 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > Date: Thu, 5 Mar 2026 16:03:15 -0300 > Cc: gdb-patches@sourceware.org > From: Guinevere Larsen <guinevere@redhat.com> > > On 3/5/26 3:56 PM, Eli Zaretskii wrote: > >> From: Guinevere Larsen <guinevere@redhat.com> > >> Cc: Guinevere Larsen <guinevere@redhat.com> > >> Date: Thu, 5 Mar 2026 15:29:30 -0300 > >> > >> User la_mettrie on IRC mentioned that they were having difficulties > >> building GDB, and after some debugging, we figured out that they weren't > >> using GNU Make. This is in the final documentation, but considering that > >> it is not an obvious place to look, and the README mentions other build > >> requirements, so this seems like a pretty obvious oversight. > >> --- > >> gdb/README | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/gdb/README b/gdb/README > >> index 492b0891668..09c88bcd19c 100644 > >> --- a/gdb/README > >> +++ b/gdb/README > >> @@ -86,8 +86,8 @@ configure the build tree.) > >> C++17 compiler for your system, you may be able to download and install > >> the GNU CC compiler. It is available via anonymous FTP from the > >> directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO > >> -C standard library. The GDB remote server, GDBserver, builds with some > >> -non-ISO standard libraries - e.g. for Windows CE. > >> +C standard library and GNU Make. The GDB remote server, GDBserver, > >> +builds with some non-ISO standard libraries - e.g. for Windows CE. > > Thanks, but shouldn't this be much closer to the beginning of the > > file, like where the build commands are first shown? Mentioning that > > here, so close to the end of the installation overview, sounds too > > late. People might overlook it. > > > That's a good point. I only put it here because it's where the other > build requirements were located, but I guess the entire paragraph should > be moved up. I will do that for v2, but while I'm at it, should we > really be teaching the user how to find a c++17 compiler? I think we > should remove the instructions on downloading GCC from the ftp > directory, and shorten the entire paragraph a bit, what do you think? Yes, I think this part of README needs a serious restructuring. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] gdb/README: Document GNU Make requirement 2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen 2026-03-05 18:56 ` Eli Zaretskii @ 2026-03-05 19:01 ` Andrew Pinski 2026-03-06 7:10 ` Eli Zaretskii 2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen 2 siblings, 1 reply; 15+ messages in thread From: Andrew Pinski @ 2026-03-05 19:01 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches On Thu, Mar 5, 2026 at 10:30 AM Guinevere Larsen <guinevere@redhat.com> wrote: > > User la_mettrie on IRC mentioned that they were having difficulties > building GDB, and after some debugging, we figured out that they weren't > using GNU Make. This is in the final documentation, but considering that > it is not an obvious place to look, and the README mentions other build > requirements, so this seems like a pretty obvious oversight. Hmm, I thought there was another seperate installation guide for gdb but nope the README is it. Eli's comment is correct but that is really about refactoring the whole README really because the mentioning of requiring a C++17 compiler should be at the same location as requring GNU make. Thanks, Andrew Pinski > --- > gdb/README | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/README b/gdb/README > index 492b0891668..09c88bcd19c 100644 > --- a/gdb/README > +++ b/gdb/README > @@ -86,8 +86,8 @@ configure the build tree.) > C++17 compiler for your system, you may be able to download and install > the GNU CC compiler. It is available via anonymous FTP from the > directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO > -C standard library. The GDB remote server, GDBserver, builds with some > -non-ISO standard libraries - e.g. for Windows CE. > +C standard library and GNU Make. The GDB remote server, GDBserver, > +builds with some non-ISO standard libraries - e.g. for Windows CE. > > GDB can optionally be built against various external libraries. > These dependencies are described below in the "`configure options" > > base-commit: 7c5179caca8cbca0f2fdb64f0fe215cee803ccb3 > prerequisite-patch-id: 47ca70553d73d20b7f4c648078529a2bb301eb64 > -- > 2.53.0 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] gdb/README: Document GNU Make requirement 2026-03-05 19:01 ` Andrew Pinski @ 2026-03-06 7:10 ` Eli Zaretskii 0 siblings, 0 replies; 15+ messages in thread From: Eli Zaretskii @ 2026-03-06 7:10 UTC (permalink / raw) To: Andrew Pinski; +Cc: guinevere, gdb-patches > From: Andrew Pinski <pinskia@gmail.com> > Date: Thu, 5 Mar 2026 11:01:34 -0800 > Cc: gdb-patches@sourceware.org > > On Thu, Mar 5, 2026 at 10:30 AM Guinevere Larsen <guinevere@redhat.com> wrote: > > > > User la_mettrie on IRC mentioned that they were having difficulties > > building GDB, and after some debugging, we figured out that they weren't > > using GNU Make. This is in the final documentation, but considering that > > it is not an obvious place to look, and the README mentions other build > > requirements, so this seems like a pretty obvious oversight. > > Hmm, I thought there was another seperate installation guide for gdb > but nope the README is it. > Eli's comment is correct but that is really about refactoring the > whole README really because the mentioning of requiring a C++17 > compiler should be at the same location as requring GNU make. Agreed. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2] gdb/README: Refactor where build requirements are explained 2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen 2026-03-05 18:56 ` Eli Zaretskii 2026-03-05 19:01 ` Andrew Pinski @ 2026-03-06 12:13 ` Guinevere Larsen 2026-03-06 14:25 ` Eli Zaretskii 2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen 2 siblings, 2 replies; 15+ messages in thread From: Guinevere Larsen @ 2026-03-06 12:13 UTC (permalink / raw) To: gdb-patches; +Cc: Guinevere Larsen User la_mettrie on IRC mentioned that they were having difficulties building GDB, and after some debugging, we figured out that they weren't using GNU Make. This is in the final documentation, but considering that it is not an obvious place to look, and the README mentions other build requirements, so this seems like a pretty obvious oversight. This commit also shortens the entire paragraph that explains the build requirements, and moves it closer to the start of the install requirements, so that they are less likely to be missed by users. --- gdb/README | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/gdb/README b/gdb/README index 492b0891668..8dc50667212 100644 --- a/gdb/README +++ b/gdb/README @@ -28,6 +28,10 @@ Configuration scripts and makefiles exist to cruise up and down this directory tree and automatically build all the pieces in the right order. + GDB requires a C++17 compiler, an ISO C standard library and GNU +Make. The GDB remote server, GDBserver, builds with some non-ISO +standard libraries - e.g. for Windows CE. + When you unpack the gdb-VERSION.tar.gz file, it will create a source directory called `gdb-VERSION'. @@ -82,13 +86,6 @@ list of options, invoke the subdirectory `configure', like: (Take note of how this differs from the invocation used to actually configure the build tree.) - GDB requires a C++17 compiler. If you do not have a -C++17 compiler for your system, you may be able to download and install -the GNU CC compiler. It is available via anonymous FTP from the -directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO -C standard library. The GDB remote server, GDBserver, builds with some -non-ISO standard libraries - e.g. for Windows CE. - GDB can optionally be built against various external libraries. These dependencies are described below in the "`configure options" section of this README. base-commit: e4fe38115fea0a9f357527959893f18ca8d51a03 -- 2.53.0 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] gdb/README: Refactor where build requirements are explained 2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen @ 2026-03-06 14:25 ` Eli Zaretskii 2026-03-06 16:43 ` Guinevere Larsen 2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen 1 sibling, 1 reply; 15+ messages in thread From: Eli Zaretskii @ 2026-03-06 14:25 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > From: Guinevere Larsen <guinevere@redhat.com> > Cc: Guinevere Larsen <guinevere@redhat.com> > Date: Fri, 6 Mar 2026 09:13:03 -0300 > > User la_mettrie on IRC mentioned that they were having difficulties > building GDB, and after some debugging, we figured out that they weren't > using GNU Make. This is in the final documentation, but considering that > it is not an obvious place to look, and the README mentions other build > requirements, so this seems like a pretty obvious oversight. > > This commit also shortens the entire paragraph that explains the build > requirements, and moves it closer to the start of the install > requirements, so that they are less likely to be missed by users. > --- > gdb/README | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/gdb/README b/gdb/README > index 492b0891668..8dc50667212 100644 > --- a/gdb/README > +++ b/gdb/README > @@ -28,6 +28,10 @@ Configuration scripts and makefiles exist to cruise up and down this > directory tree and automatically build all the pieces in the right > order. > > + GDB requires a C++17 compiler, an ISO C standard library and GNU > +Make. The GDB remote server, GDBserver, builds with some non-ISO > +standard libraries - e.g. for Windows CE. > + I'd put that a bit farther, right after this: When you unpack the gdb-VERSION.tar.gz file, it will create a source directory called `gdb-VERSION'. You can build GDB right in the source directory: cd gdb-VERSION ./configure --prefix=/usr/local (or wherever you want) make all install IMO, it's more natural, because it will directly follow the instructions for building GDB. Also, I'd begin the text with "Building GDB requires ...", to make it more clear that these are requirements for building GDB, not for using it. Thanks. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] gdb/README: Refactor where build requirements are explained 2026-03-06 14:25 ` Eli Zaretskii @ 2026-03-06 16:43 ` Guinevere Larsen 2026-03-06 19:20 ` Eli Zaretskii 0 siblings, 1 reply; 15+ messages in thread From: Guinevere Larsen @ 2026-03-06 16:43 UTC (permalink / raw) To: Eli Zaretskii; +Cc: gdb-patches On 3/6/26 11:25 AM, Eli Zaretskii wrote: >> From: Guinevere Larsen <guinevere@redhat.com> >> Cc: Guinevere Larsen <guinevere@redhat.com> >> Date: Fri, 6 Mar 2026 09:13:03 -0300 >> >> User la_mettrie on IRC mentioned that they were having difficulties >> building GDB, and after some debugging, we figured out that they weren't >> using GNU Make. This is in the final documentation, but considering that >> it is not an obvious place to look, and the README mentions other build >> requirements, so this seems like a pretty obvious oversight. >> >> This commit also shortens the entire paragraph that explains the build >> requirements, and moves it closer to the start of the install >> requirements, so that they are less likely to be missed by users. >> --- >> gdb/README | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/gdb/README b/gdb/README >> index 492b0891668..8dc50667212 100644 >> --- a/gdb/README >> +++ b/gdb/README >> @@ -28,6 +28,10 @@ Configuration scripts and makefiles exist to cruise up and down this >> directory tree and automatically build all the pieces in the right >> order. >> >> + GDB requires a C++17 compiler, an ISO C standard library and GNU >> +Make. The GDB remote server, GDBserver, builds with some non-ISO >> +standard libraries - e.g. for Windows CE. >> + > I'd put that a bit farther, right after this: > > When you unpack the gdb-VERSION.tar.gz file, it will create a > source directory called `gdb-VERSION'. > > You can build GDB right in the source directory: > > cd gdb-VERSION > ./configure --prefix=/usr/local (or wherever you want) > make all install > > IMO, it's more natural, because it will directly follow the > instructions for building GDB. I think it doesn't quite work there, because right after this it says "but we don't recommend doing that, you should instead create a build directory", so we are cutting build instructions in the middle Either we should place it before all build instructions (so after the first paragraph you placed there) or after all build instructions (before "This will configure and build .....) In my opinion we should place it first, as users (or at least I) would probably run the commands and then continue reading as the scripts run, to save a little bit of time. > > Also, I'd begin the text with "Building GDB requires ...", to make it > more clear that these are requirements for building GDB, not for using > it. Fair point, I'll update the wording for v3, once we agree on where to put it > > Thanks. > -- Cheers, Guinevere Larsen It/she ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] gdb/README: Refactor where build requirements are explained 2026-03-06 16:43 ` Guinevere Larsen @ 2026-03-06 19:20 ` Eli Zaretskii 0 siblings, 0 replies; 15+ messages in thread From: Eli Zaretskii @ 2026-03-06 19:20 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > Date: Fri, 6 Mar 2026 13:43:44 -0300 > Cc: gdb-patches@sourceware.org > From: Guinevere Larsen <guinevere@redhat.com> > > On 3/6/26 11:25 AM, Eli Zaretskii wrote: > > I'd put that a bit farther, right after this: > > > > When you unpack the gdb-VERSION.tar.gz file, it will create a > > source directory called `gdb-VERSION'. > > > > You can build GDB right in the source directory: > > > > cd gdb-VERSION > > ./configure --prefix=/usr/local (or wherever you want) > > make all install > > > > IMO, it's more natural, because it will directly follow the > > instructions for building GDB. > > I think it doesn't quite work there, because right after this it says > "but we don't recommend doing that, you should instead create a build > directory", so we are cutting build instructions in the middle We could change the wording there as well. (I always build in the source tree, and don't have any problems with that, so "we don't recommend" sounds like an exaggeration to me.) > In my opinion we should place it first, as users (or at least I) would > probably run the commands and then continue reading as the scripts run, > to save a little bit of time. That's okay, but then we should word it as prerequisites, perhaps with a heading. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3] gdb/README: Refactor where build requirements are explained 2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen 2026-03-06 14:25 ` Eli Zaretskii @ 2026-03-09 14:28 ` Guinevere Larsen 2026-03-09 14:51 ` Eli Zaretskii 1 sibling, 1 reply; 15+ messages in thread From: Guinevere Larsen @ 2026-03-09 14:28 UTC (permalink / raw) To: gdb-patches; +Cc: Guinevere Larsen User la_mettrie on IRC mentioned that they were having difficulties building GDB, and after some debugging, we figured out that they weren't using GNU Make. This is in the final documentation, but considering that it is not an obvious place to look, and the README mentions other build requirements, so this seems like a pretty obvious oversight. This commit also reworks the paragraph explaining the build requirements, turning into its own section and listing the GMP and MPFR requirements, and the section is placed before the installation section to ensure users see it before running into trouble. --- gdb/README | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gdb/README b/gdb/README index 492b0891668..ef6bdb2f1e1 100644 --- a/gdb/README +++ b/gdb/README @@ -10,6 +10,15 @@ date release information, mailing list links and archives, etc. GDB's bug tracking data base can be found at http://www.gnu.org/software/gdb/bugs/ +Build Requirements +========================== + + GDB requires a C++17 compiler, an ISO C standard library, GNU +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the +GNU Multiple Precision Floating-Point Reliable Libray. The GDB +remote server, GDBserver, builds with some non-ISO standard +libraries - e.g. for Windows CE. + Unpacking and Installation -- quick overview ========================== @@ -82,13 +91,6 @@ list of options, invoke the subdirectory `configure', like: (Take note of how this differs from the invocation used to actually configure the build tree.) - GDB requires a C++17 compiler. If you do not have a -C++17 compiler for your system, you may be able to download and install -the GNU CC compiler. It is available via anonymous FTP from the -directory `ftp://ftp.gnu.org/pub/gnu/gcc'. GDB also requires an ISO -C standard library. The GDB remote server, GDBserver, builds with some -non-ISO standard libraries - e.g. for Windows CE. - GDB can optionally be built against various external libraries. These dependencies are described below in the "`configure options" section of this README. base-commit: e4fe38115fea0a9f357527959893f18ca8d51a03 -- 2.53.0 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3] gdb/README: Refactor where build requirements are explained 2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen @ 2026-03-09 14:51 ` Eli Zaretskii 2026-03-09 16:27 ` Guinevere Larsen 0 siblings, 1 reply; 15+ messages in thread From: Eli Zaretskii @ 2026-03-09 14:51 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > From: Guinevere Larsen <guinevere@redhat.com> > Cc: Guinevere Larsen <guinevere@redhat.com> > Date: Mon, 9 Mar 2026 11:28:33 -0300 > > +Build Requirements > +========================== > + > + GDB requires a C++17 compiler, an ISO C standard library, GNU > +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the > +GNU Multiple Precision Floating-Point Reliable Libray. The GDB > +remote server, GDBserver, builds with some non-ISO standard > +libraries - e.g. for Windows CE. > + This LGTM, with one nit: I would suggest to state the acronym for MPFR in parentheses, in case the reader is not familiar with its full name, like you did with GMP. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3] gdb/README: Refactor where build requirements are explained 2026-03-09 14:51 ` Eli Zaretskii @ 2026-03-09 16:27 ` Guinevere Larsen 2026-03-09 16:41 ` Eli Zaretskii 0 siblings, 1 reply; 15+ messages in thread From: Guinevere Larsen @ 2026-03-09 16:27 UTC (permalink / raw) To: Eli Zaretskii; +Cc: gdb-patches On 3/9/26 11:51 AM, Eli Zaretskii wrote: >> From: Guinevere Larsen <guinevere@redhat.com> >> Cc: Guinevere Larsen <guinevere@redhat.com> >> Date: Mon, 9 Mar 2026 11:28:33 -0300 >> >> +Build Requirements >> +========================== >> + >> + GDB requires a C++17 compiler, an ISO C standard library, GNU >> +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the >> +GNU Multiple Precision Floating-Point Reliable Libray. The GDB >> +remote server, GDBserver, builds with some non-ISO standard >> +libraries - e.g. for Windows CE. >> + > This LGTM, with one nit: I would suggest to state the acronym for MPFR > in parentheses, in case the reader is not familiar with its full name, > like you did with GMP. > Fixed! Is your approval enough to push the patch? I am not sure about the readme.... -- Cheers, Guinevere Larsen It/she ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3] gdb/README: Refactor where build requirements are explained 2026-03-09 16:27 ` Guinevere Larsen @ 2026-03-09 16:41 ` Eli Zaretskii 2026-03-09 16:58 ` Pierre Muller 0 siblings, 1 reply; 15+ messages in thread From: Eli Zaretskii @ 2026-03-09 16:41 UTC (permalink / raw) To: Guinevere Larsen; +Cc: gdb-patches > Date: Mon, 9 Mar 2026 13:27:07 -0300 > From: Guinevere Larsen <guinevere@redhat.com> > Cc: gdb-patches@sourceware.org > > On 3/9/26 11:51 AM, Eli Zaretskii wrote: > >> From: Guinevere Larsen <guinevere@redhat.com> > >> Cc: Guinevere Larsen <guinevere@redhat.com> > >> Date: Mon, 9 Mar 2026 11:28:33 -0300 > >> > >> +Build Requirements > >> +========================== > >> + > >> + GDB requires a C++17 compiler, an ISO C standard library, GNU > >> +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the > >> +GNU Multiple Precision Floating-Point Reliable Libray. The GDB > >> +remote server, GDBserver, builds with some non-ISO standard > >> +libraries - e.g. for Windows CE. > >> + > > This LGTM, with one nit: I would suggest to state the acronym for MPFR > > in parentheses, in case the reader is not familiar with its full name, > > like you did with GMP. > > > Fixed! > > Is your approval enough to push the patch? I am not sure about the > readme.... I think it's enough, but in this case I suggest to wait a little bit for others to chime in, since this change already triggered various comments from them. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3] gdb/README: Refactor where build requirements are explained 2026-03-09 16:41 ` Eli Zaretskii @ 2026-03-09 16:58 ` Pierre Muller 0 siblings, 0 replies; 15+ messages in thread From: Pierre Muller @ 2026-03-09 16:58 UTC (permalink / raw) To: gdb-patches Le 09/03/2026 à 17:41, Eli Zaretskii a écrit : >> Date: Mon, 9 Mar 2026 13:27:07 -0300 >> From: Guinevere Larsen <guinevere@redhat.com> >> Cc: gdb-patches@sourceware.org >> >> On 3/9/26 11:51 AM, Eli Zaretskii wrote: >>>> From: Guinevere Larsen <guinevere@redhat.com> >>>> Cc: Guinevere Larsen <guinevere@redhat.com> >>>> Date: Mon, 9 Mar 2026 11:28:33 -0300 >>>> >>>> +Build Requirements >>>> +========================== >>>> + >>>> + GDB requires a C++17 compiler, an ISO C standard library, GNU >>>> +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the >>>> +GNU Multiple Precision Floating-Point Reliable Libray. The GDB >>>> +remote server, GDBserver, builds with some non-ISO standard >>>> +libraries - e.g. for Windows CE. >>>> + >>> This LGTM, with one nit: I would suggest to state the acronym for MPFR >>> in parentheses, in case the reader is not familiar with its full name, >>> like you did with GMP. >>> >> Fixed! >> >> Is your approval enough to push the patch? I am not sure about the >> readme.... > > I think it's enough, but in this case I suggest to wait a little bit > for others to chime in, since this change already triggered various > comments from them. I just noticed a small typo: Multiple Precision Floating-Point Reliable Libray. should be changed into: Multiple Precision Floating-Point Reliable Library. Pierre ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2026-03-09 16:59 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen 2026-03-05 18:56 ` Eli Zaretskii 2026-03-05 19:03 ` Guinevere Larsen 2026-03-06 7:11 ` Eli Zaretskii 2026-03-05 19:01 ` Andrew Pinski 2026-03-06 7:10 ` Eli Zaretskii 2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen 2026-03-06 14:25 ` Eli Zaretskii 2026-03-06 16:43 ` Guinevere Larsen 2026-03-06 19:20 ` Eli Zaretskii 2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen 2026-03-09 14:51 ` Eli Zaretskii 2026-03-09 16:27 ` Guinevere Larsen 2026-03-09 16:41 ` Eli Zaretskii 2026-03-09 16:58 ` Pierre Muller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox