From: Guinevere Larsen <guinevere@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/README: Refactor where build requirements are explained
Date: Fri, 6 Mar 2026 13:43:44 -0300 [thread overview]
Message-ID: <feb2891a-1a8b-49db-99e1-5bfc6a0832a4@redhat.com> (raw)
In-Reply-To: <86zf4lt4p6.fsf@gnu.org>
On 3/6/26 11:25 AM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>
>> Date: Fri, 6 Mar 2026 09:13:03 -0300
>>
>> User la_mettrie on IRC mentioned that they were having difficulties
>> building GDB, and after some debugging, we figured out that they weren't
>> using GNU Make. This is in the final documentation, but considering that
>> it is not an obvious place to look, and the README mentions other build
>> requirements, so this seems like a pretty obvious oversight.
>>
>> This commit also shortens the entire paragraph that explains the build
>> requirements, and moves it closer to the start of the install
>> requirements, so that they are less likely to be missed by users.
>> ---
>> gdb/README | 11 ++++-------
>> 1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> diff --git a/gdb/README b/gdb/README
>> index 492b0891668..8dc50667212 100644
>> --- a/gdb/README
>> +++ b/gdb/README
>> @@ -28,6 +28,10 @@ Configuration scripts and makefiles exist to cruise up and down this
>> directory tree and automatically build all the pieces in the right
>> order.
>>
>> + GDB requires a C++17 compiler, an ISO C standard library and GNU
>> +Make. The GDB remote server, GDBserver, builds with some non-ISO
>> +standard libraries - e.g. for Windows CE.
>> +
> I'd put that a bit farther, right after this:
>
> When you unpack the gdb-VERSION.tar.gz file, it will create a
> source directory called `gdb-VERSION'.
>
> You can build GDB right in the source directory:
>
> cd gdb-VERSION
> ./configure --prefix=/usr/local (or wherever you want)
> make all install
>
> IMO, it's more natural, because it will directly follow the
> instructions for building GDB.
I think it doesn't quite work there, because right after this it says
"but we don't recommend doing that, you should instead create a build
directory", so we are cutting build instructions in the middle
Either we should place it before all build instructions (so after the
first paragraph you placed there) or after all build instructions
(before "This will configure and build .....)
In my opinion we should place it first, as users (or at least I) would
probably run the commands and then continue reading as the scripts run,
to save a little bit of time.
>
> Also, I'd begin the text with "Building GDB requires ...", to make it
> more clear that these are requirements for building GDB, not for using
> it.
Fair point, I'll update the wording for v3, once we agree on where to
put it
>
> Thanks.
>
--
Cheers,
Guinevere Larsen
It/she
next prev parent reply other threads:[~2026-03-06 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen
2026-03-05 18:56 ` Eli Zaretskii
2026-03-05 19:03 ` Guinevere Larsen
2026-03-06 7:11 ` Eli Zaretskii
2026-03-05 19:01 ` Andrew Pinski
2026-03-06 7:10 ` Eli Zaretskii
2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen
2026-03-06 14:25 ` Eli Zaretskii
2026-03-06 16:43 ` Guinevere Larsen [this message]
2026-03-06 19:20 ` Eli Zaretskii
2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen
2026-03-09 14:51 ` Eli Zaretskii
2026-03-09 16:27 ` Guinevere Larsen
2026-03-09 16:41 ` Eli Zaretskii
2026-03-09 16:58 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb2891a-1a8b-49db-99e1-5bfc6a0832a4@redhat.com \
--to=guinevere@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox