From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TDSBMd0Eq2lLGxkAWB0awg (envelope-from ) for ; Fri, 06 Mar 2026 11:46:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H8wTku/N; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B4B661E089; Fri, 06 Mar 2026 11:46:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E67731E089 for ; Fri, 06 Mar 2026 11:46:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 65E624BA23E4 for ; Fri, 6 Mar 2026 16:46:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65E624BA23E4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H8wTku/N Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2CDA24BA2E1D for ; Fri, 6 Mar 2026 16:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CDA24BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CDA24BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772815430; cv=none; b=n/JxfFZtuEKvFD/GZJtIdmyzl+4xllA2v6MlvVEUuxom0FKYfNtG30KggD1EcDf0Sb4nLgXJfXxZirNGC4jluD5dL9rkNUiRu6XkO8VdRySJSCWKtK1zRU0Ep2GK2ak0t5LRu9Yy65QffmMgp9DCEoG2MRii76AWLPLuK8C2AmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772815430; c=relaxed/simple; bh=gn6vjy9/celRcJb23kFy5jkrZG6X3pdI4JP37uLC6UA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GR0ZBYSTtnSwx9prYx/oiQ7+p/sk77mDpADSrJnEnn/55bD6kGhjCaQT2QkDSVI/OrYbC0x33daQ43/DHsF6u6X93VUdSYjbf04nZMMlZAA4QA82tIRK0IDc7U0yJZtJk9oCy384vYnGtSSJ9G5D9uQOUdytjuFA7SRo90R51UA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CDA24BA2E1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772815429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zHG/WlJno7q/OB3VmA30OuH2Q30HI6A/ezzwz7/t58k=; b=H8wTku/NIvlDdJ/Hl2uW84BVVu/Te6CyYPJ7F6RN7G5rebE93d7A4ssdxaKyaZerXv6W1N JpfYuqSQ5v7zGDia/1AdCqRN7WpXEOCOm8cWStc2cpkn3LlXFNJLNDY716d6N25fn5ADfa Ll36CzRSBjHJB9QySO3k7Ut5hlvn0DU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-LIJ-_YdkMQyfjPPyKn38fQ-1; Fri, 06 Mar 2026 11:43:48 -0500 X-MC-Unique: LIJ-_YdkMQyfjPPyKn38fQ-1 X-Mimecast-MFC-AGG-ID: LIJ-_YdkMQyfjPPyKn38fQ_1772815428 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3d11b913so5170457485a.1 for ; Fri, 06 Mar 2026 08:43:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815428; x=1773420228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zHG/WlJno7q/OB3VmA30OuH2Q30HI6A/ezzwz7/t58k=; b=bsk8ReUSU/JmG/6D+PfF3raCISo47y+iMOqLCrjDEO7pwavrq5L3y+IWspZ2m/6CYc YafP94Rkz4FWIa62PvpgQD8C1qqqYv3LlZ5UHTENNJy8qWs7TDceignAstU7T+mQedr6 KxpI3R6UjoTX0gpb8iDk+7o1fdtsMSFMuSQ5jQHtgM2OfGjuF87ZS9ilrsxAtWO4BCP6 suCvstPl7JtK+oewYb7X/0mo02an4UBPLzXl2rtXqM4s5PodaCHNDLmyC3xRubDmtYtd G7Ru7odkzFA1FjjG5HCOgsrwT/n6suvYFUvWc/bUhb0eJO2udbAIYHfxV9P5iPJP4qIS qclg== X-Gm-Message-State: AOJu0Yx/cdC8C/OX/ZBW7KN6YR0qCv0jQmPqp9MOI0Gzl7dLxLqJ2002 IUjRSyhBV93livIoqicTKyH+E8T6yr1lM2IohbOPxofYgogHXv2xPUH6bwRPd8aOs/rGa8/o/Lr vDqmiWSwYs0SrTq8ME9g6r88UDojo/BFgtQ7kY0m4LM0pwYt51TdEGVuQ93xdNfE= X-Gm-Gg: ATEYQzwMzjSCH2OXxM80iXa4RhngclUDsrX0qanxcK7piMZBgU9hOMQfafQF63I8bml Xwu49d10wINCoGhstXhMmvyejKrdmg38w6j1KngJZ1Ni+mmEkidgKCR0+M8XJD8eRvhl9EgOef+ LT3grm1JIktm945WIuoS1yGCwvtAM0cnL4ee7/YZWYpcpY/4QrmXyEjYjIxZMfV1p5F6yF8/EbI NHSpCeUott3cb21/Z1e2GHLT95OdWjNsXSQ25x7d4bMXNH8dGOgvAA+CxL7R469DFzZpwxSIXsl YW0h3b7YYuUBhQQ3Q3diQE6p8geMabZhk8ksb9btuYayq+uUTysX/AQgf1PN3UvJBA1ymd/g2Zp gs7fXT4l3VPugSqDj2ZDvlryCExPwPzo= X-Received: by 2002:a05:620a:7005:b0:8c7:1afd:a535 with SMTP id af79cd13be357-8cd6d386057mr448136485a.25.1772815428390; Fri, 06 Mar 2026 08:43:48 -0800 (PST) X-Received: by 2002:a05:620a:7005:b0:8c7:1afd:a535 with SMTP id af79cd13be357-8cd6d386057mr448134085a.25.1772815427976; Fri, 06 Mar 2026 08:43:47 -0800 (PST) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd6f49649esm143903185a.12.2026.03.06.08.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 08:43:47 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 13:43:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/README: Refactor where build requirements are explained To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20260305182930.4119998-1-guinevere@redhat.com> <20260306121303.2358881-1-guinevere@redhat.com> <86zf4lt4p6.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86zf4lt4p6.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: D3db5QPznxUaJUjC63GNL5GRssISE2Xgbk0-HNa5DQc_1772815428 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/6/26 11:25 AM, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Fri, 6 Mar 2026 09:13:03 -0300 >> >> User la_mettrie on IRC mentioned that they were having difficulties >> building GDB, and after some debugging, we figured out that they weren't >> using GNU Make. This is in the final documentation, but considering that >> it is not an obvious place to look, and the README mentions other build >> requirements, so this seems like a pretty obvious oversight. >> >> This commit also shortens the entire paragraph that explains the build >> requirements, and moves it closer to the start of the install >> requirements, so that they are less likely to be missed by users. >> --- >> gdb/README | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/gdb/README b/gdb/README >> index 492b0891668..8dc50667212 100644 >> --- a/gdb/README >> +++ b/gdb/README >> @@ -28,6 +28,10 @@ Configuration scripts and makefiles exist to cruise up and down this >> directory tree and automatically build all the pieces in the right >> order. >> >> + GDB requires a C++17 compiler, an ISO C standard library and GNU >> +Make. The GDB remote server, GDBserver, builds with some non-ISO >> +standard libraries - e.g. for Windows CE. >> + > I'd put that a bit farther, right after this: > > When you unpack the gdb-VERSION.tar.gz file, it will create a > source directory called `gdb-VERSION'. > > You can build GDB right in the source directory: > > cd gdb-VERSION > ./configure --prefix=/usr/local (or wherever you want) > make all install > > IMO, it's more natural, because it will directly follow the > instructions for building GDB. I think it doesn't quite work there, because right after this it says "but we don't recommend doing that, you should instead create a build directory", so we are cutting build instructions in the middle Either we should place it before all build instructions (so after the first paragraph you placed there) or after all build instructions (before "This will configure and build .....) In my opinion we should place it first, as users (or at least I) would probably run the commands and then continue reading as the scripts run, to save a little bit of time. > > Also, I'd begin the text with "Building GDB requires ...", to make it > more clear that these are requirements for building GDB, not for using > it. Fair point, I'll update the wording for v3, once we agree on where to put it > > Thanks. > -- Cheers, Guinevere Larsen It/she