From: Guinevere Larsen <guinevere@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb/README: Refactor where build requirements are explained
Date: Mon, 9 Mar 2026 13:27:07 -0300 [thread overview]
Message-ID: <0933ae40-b138-4108-abb7-ced3cb37296f@redhat.com> (raw)
In-Reply-To: <865x75qcn2.fsf@gnu.org>
On 3/9/26 11:51 AM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>
>> Date: Mon, 9 Mar 2026 11:28:33 -0300
>>
>> +Build Requirements
>> +==========================
>> +
>> + GDB requires a C++17 compiler, an ISO C standard library, GNU
>> +Make, the GNU Multiple Precision Arithmetic Library (GMP), and the
>> +GNU Multiple Precision Floating-Point Reliable Libray. The GDB
>> +remote server, GDBserver, builds with some non-ISO standard
>> +libraries - e.g. for Windows CE.
>> +
> This LGTM, with one nit: I would suggest to state the acronym for MPFR
> in parentheses, in case the reader is not familiar with its full name,
> like you did with GMP.
>
Fixed!
Is your approval enough to push the patch? I am not sure about the
readme....
--
Cheers,
Guinevere Larsen
It/she
next prev parent reply other threads:[~2026-03-09 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 18:29 [PATCH] gdb/README: Document GNU Make requirement Guinevere Larsen
2026-03-05 18:56 ` Eli Zaretskii
2026-03-05 19:03 ` Guinevere Larsen
2026-03-06 7:11 ` Eli Zaretskii
2026-03-05 19:01 ` Andrew Pinski
2026-03-06 7:10 ` Eli Zaretskii
2026-03-06 12:13 ` [PATCH v2] gdb/README: Refactor where build requirements are explained Guinevere Larsen
2026-03-06 14:25 ` Eli Zaretskii
2026-03-06 16:43 ` Guinevere Larsen
2026-03-06 19:20 ` Eli Zaretskii
2026-03-09 14:28 ` [PATCH v3] " Guinevere Larsen
2026-03-09 14:51 ` Eli Zaretskii
2026-03-09 16:27 ` Guinevere Larsen [this message]
2026-03-09 16:41 ` Eli Zaretskii
2026-03-09 16:58 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0933ae40-b138-4108-abb7-ced3cb37296f@redhat.com \
--to=guinevere@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox