Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE

[Yao Qi <qiyaoltc@gmail.com>]

Alan Hayward <Alan.Hayward@arm.com> writes:

> Tested on a --enable-targets=all and --enable-libsanitizer build using

Beside --enable-targets=all, do you configure with --enable-64-bit-bfd?

Why do you configure with --enable-libsanitizer?  It is a top-level
configure option which enables to build libsanitizer.  What we need here
is to build GDB with ASAN like this,

 $ make CXXFLAGS='-fsanitize=address' gdb

and run gdb.gdb/unittest.exp.

>
>
> diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c
> index 7282acb20ac2c25e7f2c48fec3106300c385679f..d396fb81a62b0c2522900fd9cb0980aa2a5fb767 100644
> --- a/gdb/ia64-tdep.c
> +++ b/gdb/ia64-tdep.c
> @@ -125,6 +125,9 @@ static CORE_ADDR ia64_find_global_pointer (struct gdbarch *gdbarch,
>
>  #define NUM_IA64_RAW_REGS 462
>
> +/* Big enough to hold a FP register in bytes.  */
> +#define IA64_FP_REGISTER_SIZE 16

Nit, we can replace one magic number 128 with this macro in ia64_ext_type,

  if (!tdep->ia64_ext_type)
    tdep->ia64_ext_type
      = arch_float_type (gdbarch, 128, "builtin_type_ia64_ext",
			 floatformats_ia64_ext);

Patch is OK if there is no fail in gdb.gdb/unittest.exp.

-- 
Yao (齐尧)