From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75186 invoked by alias); 6 Jun 2017 10:04:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75156 invoked by uid 89); 6 Jun 2017 10:04:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static., Big X-HELO: mail-it0-f66.google.com Received: from mail-it0-f66.google.com (HELO mail-it0-f66.google.com) (209.85.214.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Jun 2017 10:04:37 +0000 Received: by mail-it0-f66.google.com with SMTP id d68so26563074ita.1 for ; Tue, 06 Jun 2017 03:04:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=d6Jw2bu1g9Jjnwjy8CaZ/qDelHSJA63mle31YTAnfoA=; b=K/Avc3q5JghJTpCsqp0r9UR++YR0u1B4ZWlO56acTnKzyEPJetT+2W0w5KB8i78ILb fo8+Le3LNltc5Zb1vldlDDiyuCpcsNPLXoWA8xLExCEgp+4dKRUlh5YvBtwSB/Xea5ut 31zLwQqUJyHd8Q4hu0/C3trJXdsoX8mMQMc/PaBbg3xMf0Li8BX1BeBI4hiHWMrWUFDt //YVlA4DsB9vjmRE2er2cX8UePk5MLjb7I4ZdJL4eOsb9/7xhGutMDWubSM+21qDTN+F QVZybvxHyPgEWFqfax+ZIncO4dYgLndVn6rvu5FdNvOh7nSSCu3JfizHxWiZVVp+B3kQ RscA== X-Gm-Message-State: AODbwcDsuDRH9CFsQ3rZ4AgmETcBRJpXleuPdPDHinETynwtLElvfTC+ WtunkR2uXDe5hA== X-Received: by 10.107.187.135 with SMTP id l129mr23370345iof.219.1496743480356; Tue, 06 Jun 2017 03:04:40 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id g12sm15602358iog.60.2017.06.06.03.04.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 06 Jun 2017 03:04:39 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE References: <8637dnqils.fsf@gmail.com> <90F5717F-8685-4C74-B2E4-7317AF228034@arm.com> <86pogivp7m.fsf@gmail.com> <0CAAE3E4-1860-40FF-895E-6C6A54A4EAB6@arm.com> <86vapsqxld.fsf@gmail.com> <498D342A-2994-4664-968D-F97A80C66059@arm.com> <86mvb2p32v.fsf@gmail.com> <79E51549-1B65-4DA8-891A-17EF061E03A3@arm.com> Date: Tue, 06 Jun 2017 10:04:00 -0000 In-Reply-To: <79E51549-1B65-4DA8-891A-17EF061E03A3@arm.com> (Alan Hayward's message of "Mon, 5 Jun 2017 16:27:57 +0000") Message-ID: <861sqx300d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00138.txt.bz2 Alan Hayward writes: > Tested on a --enable-targets=3Dall and --enable-libsanitizer build using Beside --enable-targets=3Dall, do you configure with --enable-64-bit-bfd? Why do you configure with --enable-libsanitizer? It is a top-level configure option which enables to build libsanitizer. What we need here is to build GDB with ASAN like this, $ make CXXFLAGS=3D'-fsanitize=3Daddress' gdb and run gdb.gdb/unittest.exp. > > > diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c > index 7282acb20ac2c25e7f2c48fec3106300c385679f..d396fb81a62b0c2522900fd9c= b0980aa2a5fb767 100644 > --- a/gdb/ia64-tdep.c > +++ b/gdb/ia64-tdep.c > @@ -125,6 +125,9 @@ static CORE_ADDR ia64_find_global_pointer (struct gdb= arch *gdbarch, > > #define NUM_IA64_RAW_REGS 462 > > +/* Big enough to hold a FP register in bytes. */ > +#define IA64_FP_REGISTER_SIZE 16 Nit, we can replace one magic number 128 with this macro in ia64_ext_type, if (!tdep->ia64_ext_type) tdep->ia64_ext_type =3D arch_float_type (gdbarch, 128, "builtin_type_ia64_ext", floatformats_ia64_ext); Patch is OK if there is no fail in gdb.gdb/unittest.exp. --=20 Yao (=E9=BD=90=E5=B0=A7)