Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE

[Alan Hayward <Alan.Hayward@arm.com>]

> On 27 Apr 2017, at 11:17, Yao Qi <qiyaoltc@gmail.com> wrote:
> 
> Alan Hayward <Alan.Hayward@arm.com> writes:
> 
> Hi Alan,
> As I keep saying, please split your patch.  You have two complete
> different approaches in this patch to remove MAX_FP_REGISTER_SIZE, and
> each of them is independent of the other.  One looks very correct to me
> but I am not sure the other one.  This leads to that part of the patch
> can go in.
> 
>> 2017-04-26  Alan Hayward  <alan.hayward@arm.com>
>> 
>> 	* ia64-tdep.c (IA64_MAX_FP_REGISTER_SIZE) Add.
>> 	(ia64_register_to_value): Use IA64_MAX_FP_REGISTER_SIZE.
>> 	(ia64_value_to_register): Likewise.
>> 	(examine_prologue): Use get_frame_register_unsigned.
>> 	(ia64_sigtramp_frame_prev_register): Use extract_unsigned_integer.
> 
> Use read_memory_unsigned_integer.
> 
>> 	(ia64_access_reg): Likewise.
> 
> Use get_frame_register_unsigned.
> 
>> 	(ia64_access_rse_reg): Likewise.
>> 	(ia64_libunwind_frame_prev_register): Likewise.
>> 	(ia64_extract_return_value): Use IA64_MAX_FP_REGISTER_SIZE.
>> 	(ia64_store_return_value): Likewise.
>> 	(ia64_push_dummy_call): Likewise.
>> 
>> 
>> diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c
>> index 22e158866bbbf0d9457737ac973027521e2c1655..4f19e15acdcf34816c10bcab6884659c6688f6bf 100644
> 

<snip>

> This part of the patch (not using IA64_MAX_FP_REGISTER_SIZE) is good
> to me.
> 

Above patch pushed.
That leaves this patch to be reviewed:


2017-04-27  Alan Hayward  <alan.hayward@arm.com>

	* ia64-tdep.c (IA64_MAX_FP_REGISTER_SIZE) Add.
	(ia64_register_to_value): Use IA64_MAX_FP_REGISTER_SIZE.
	(ia64_value_to_register): Likewise.
	(ia64_extract_return_value): Likewise.
	(ia64_store_return_value): Likewise.
	(ia64_push_dummy_call): Likewise.


diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c
index 8583450fee89e4f0cb6a779efde95c692e097199..4f19e15acdcf34816c10bcab6884659c6688f6bf 100644
--- a/gdb/ia64-tdep.c
+++ b/gdb/ia64-tdep.c
@@ -125,6 +125,9 @@ static CORE_ADDR ia64_find_global_pointer (struct gdbarch *gdbarch,

 #define NUM_IA64_RAW_REGS 462

+/* Big enough to hold a FP register in bytes.  */
+#define IA64_FP_REGISTER_SIZE 16
+
 static int sp_regnum = IA64_GR12_REGNUM;

 /* NOTE: we treat the register stack registers r32-r127 as
@@ -1227,7 +1230,7 @@ ia64_register_to_value (struct frame_info *frame, int regnum,
 			int *optimizedp, int *unavailablep)
 {
   struct gdbarch *gdbarch = get_frame_arch (frame);
-  gdb_byte in[MAX_REGISTER_SIZE];
+  gdb_byte in[IA64_FP_REGISTER_SIZE];

   /* Convert to TYPE.  */
   if (!get_frame_register_bytes (frame, regnum, 0,
@@ -1245,7 +1248,7 @@ ia64_value_to_register (struct frame_info *frame, int regnum,
                          struct type *valtype, const gdb_byte *in)
 {
   struct gdbarch *gdbarch = get_frame_arch (frame);
-  gdb_byte out[MAX_REGISTER_SIZE];
+  gdb_byte out[IA64_FP_REGISTER_SIZE];
   convert_typed_floating (in, valtype, out, ia64_ext_type (gdbarch));
   put_frame_register (frame, regnum, out);
 }
@@ -3208,7 +3211,7 @@ ia64_extract_return_value (struct type *type, struct regcache *regcache,
   float_elt_type = is_float_or_hfa_type (type);
   if (float_elt_type != NULL)
     {
-      gdb_byte from[MAX_REGISTER_SIZE];
+      gdb_byte from[IA64_FP_REGISTER_SIZE];
       int offset = 0;
       int regnum = IA64_FR8_REGNUM;
       int n = TYPE_LENGTH (type) / TYPE_LENGTH (float_elt_type);
@@ -3273,7 +3276,7 @@ ia64_store_return_value (struct type *type, struct regcache *regcache,
   float_elt_type = is_float_or_hfa_type (type);
   if (float_elt_type != NULL)
     {
-      gdb_byte to[MAX_REGISTER_SIZE];
+      gdb_byte to[IA64_FP_REGISTER_SIZE];
       int offset = 0;
       int regnum = IA64_FR8_REGNUM;
       int n = TYPE_LENGTH (type) / TYPE_LENGTH (float_elt_type);
@@ -3835,7 +3838,7 @@ ia64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
 	  len = TYPE_LENGTH (type);
 	  while (len > 0 && floatreg < IA64_FR16_REGNUM)
 	    {
-	      gdb_byte to[MAX_REGISTER_SIZE];
+	      gdb_byte to[IA64_FP_REGISTER_SIZE];
 	      convert_typed_floating (value_contents (arg) + argoffset,
 				      float_elt_type, to,
 				      ia64_ext_type (gdbarch));