From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: Remove some duplication from gdb.mi/mi-var-child.exp
Date: Thu, 6 Jan 2022 16:44:05 +0000 [thread overview]
Message-ID: <844a86c1-9418-0e38-180a-1e6727c66383@palves.net> (raw)
In-Reply-To: <20211217232439.urx6zd2egmwntmje@Plymouth>
On 2021-12-17 23:24, Lancelot SIX wrote:
>> That is certainly fine. Please go ahead with what you had.
>>
>> I gave it another look, and noticed that at least the "get number of children" tests
>> can be easily factored out, like below. This applies on top of your patch.
>>
>> WDYT?
>>
>
> Nice!
>
> I was expecting something similar could be done, but I did not pushed to
> do it. It looks good, and I confirm that I have no difference in the
> .sum file.
>
> I am confident this is OK, and I have integrated this patch in my
> branch. If this is OK, I'll push with the rest of my series.
Sorry, missed this question before. Yes, this is totally fine, and actually
less work for me, so thanks. :-)
next prev parent reply other threads:[~2022-01-06 16:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 23:00 [PATCH 00/12] Remove DUPLICATEs warnings Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 01/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-syn-frame.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 02/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nsthrexec.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 03/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-watch.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 04/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-catch-load.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55 ` Pedro Alves
2021-12-16 23:27 ` Lancelot SIX via Gdb-patches
2021-12-17 12:21 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 05/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-child.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55 ` Pedro Alves
2021-12-16 23:40 ` Lancelot SIX via Gdb-patches
2021-12-17 13:00 ` [PATCH] gdb/testsuite: Remove some duplication " Pedro Alves
2021-12-17 23:24 ` Lancelot SIX via Gdb-patches
2022-01-06 16:44 ` Pedro Alves [this message]
2021-11-26 23:00 ` [PATCH 06/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-var-child.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 07/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 08/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop-exit.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-16 23:48 ` Lancelot SIX via Gdb-patches
2021-12-17 13:52 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 09/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-rtti.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-16 23:59 ` Lancelot SIX via Gdb-patches
2021-12-17 13:53 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-17 22:57 ` Lancelot SIX via Gdb-patches
2022-01-06 16:49 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 12/12] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex Lancelot SIX via Gdb-patches
2021-12-09 18:15 ` [PATCH 00/12] Remove DUPLICATEs warnings Tom Tromey
2021-12-10 22:01 ` Pedro Alves
2022-01-07 22:43 ` Lancelot SIX via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=844a86c1-9418-0e38-180a-1e6727c66383@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox