From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 04/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-catch-load.exp
Date: Fri, 17 Dec 2021 12:21:12 +0000 [thread overview]
Message-ID: <80151bc1-bf1d-ea2f-aa95-9610e9130d20@palves.net> (raw)
In-Reply-To: <20211216232711.oke7xqfsvfn44wk4@Plymouth>
On 2021-12-16 23:27, Lancelot SIX wrote:
> From 6fcb1d880bf5009aa9ce9e873a5c5f50e6fc142d Mon Sep 17 00:00:00 2001
> From: Lancelot SIX <lsix@lancelotsix.com>
> Date: Mon, 22 Nov 2021 22:36:47 +0000
> Subject: [PATCH] gdb/testsuite: Remove duplicates from
> gdb.mi/mi-catch-load.exp
>
> When I run the testsuite, I have:
>
> Running .../gdb/testsuite/gdb.mi/mi-catch-load.exp ...
> DUPLICATE: gdb.mi/mi-catch-load.exp: breakpoint at main
> DUPLICATE: gdb.mi/mi-catch-load.exp: mi runto main
>
> Fix by grouping the various phases in with_test_prefix blocks. Since
> the tests now have a prefix, remove the manually written prefixes in
> testnames.
>
> Also change some messages with the pattern "(timeout) $testname" into
> "$estname (timeout)" since tools will handle this as $testname[1] (which
> is what we want in this particular scenario).
>
> Tested on x86_64-linux.
>
> [1] https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
Perfect. This is OK.
next prev parent reply other threads:[~2021-12-17 12:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 23:00 [PATCH 00/12] Remove DUPLICATEs warnings Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 01/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-syn-frame.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 02/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nsthrexec.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 03/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-watch.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 04/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-catch-load.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55 ` Pedro Alves
2021-12-16 23:27 ` Lancelot SIX via Gdb-patches
2021-12-17 12:21 ` Pedro Alves [this message]
2021-11-26 23:00 ` [PATCH 05/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-child.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55 ` Pedro Alves
2021-12-16 23:40 ` Lancelot SIX via Gdb-patches
2021-12-17 13:00 ` [PATCH] gdb/testsuite: Remove some duplication " Pedro Alves
2021-12-17 23:24 ` Lancelot SIX via Gdb-patches
2022-01-06 16:44 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 06/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-var-child.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 07/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 08/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop-exit.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-16 23:48 ` Lancelot SIX via Gdb-patches
2021-12-17 13:52 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 09/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-rtti.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-16 23:59 ` Lancelot SIX via Gdb-patches
2021-12-17 13:53 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56 ` Pedro Alves
2021-12-17 22:57 ` Lancelot SIX via Gdb-patches
2022-01-06 16:49 ` Pedro Alves
2021-11-26 23:00 ` [PATCH 12/12] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex Lancelot SIX via Gdb-patches
2021-12-09 18:15 ` [PATCH 00/12] Remove DUPLICATEs warnings Tom Tromey
2021-12-10 22:01 ` Pedro Alves
2022-01-07 22:43 ` Lancelot SIX via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80151bc1-bf1d-ea2f-aa95-9610e9130d20@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox