From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X5JiI8eAvGEPCgAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 07:21:27 -0500 Received: by simark.ca (Postfix, from userid 112) id 800951F0CE; Fri, 17 Dec 2021 07:21:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 05AF21F0B9 for ; Fri, 17 Dec 2021 07:21:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E0713858430 for ; Fri, 17 Dec 2021 12:21:26 +0000 (GMT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id 1A0C73858D28 for ; Fri, 17 Dec 2021 12:21:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A0C73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id j18so3736404wrd.2 for ; Fri, 17 Dec 2021 04:21:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZeSviAQLYTW7qnvzfipQ/ftu19rvPdL638vWwKAK4zY=; b=oGPdsTQs1iPAPS1yOIWg6MekwupwPUkBkU4Viahy9vI+hriZ3nfNuuSzY9BeTY7EoD +boxq83kJVVa8HNR4VuCh27vPIyenRFRSVzSnkcQi2VkwPtWAEzh+kQJyFmbVacsa5HL oOpBV+tI3O5fhf6uYiBJzE9ct1MKRUrMYDHLG2aLIbSo6F8t0vVUk7etGdzxKyUipNtk t2tH9Kz8bLGLzqAGBO4SkZqo/itCkCDLboB7r9PbalzWmEqtaEw+n5wMickERLfM4h5I /U2fe7OuMhLyYpIN2EkUpmWn5F0N9IM6FT/BGl9xhtFWY4wY5psykEteoMZ1s484uuJT 8lfw== X-Gm-Message-State: AOAM5335tTHtDibobRwL5ophUjb4yPKdBc/bc5jGu+T2HVhyg/InUE6q MNdcreIqCZHJ1icIc3vUeHw= X-Google-Smtp-Source: ABdhPJyXZDDmr1VwW3zyEW3HUNDURMrk8LfsL4ce/TpmhtNoiXcvyvgoiqFtrvkkAzhdekKsLxzPEQ== X-Received: by 2002:a05:6000:188b:: with SMTP id a11mr2452903wri.326.1639743674133; Fri, 17 Dec 2021 04:21:14 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id q206sm3373088wme.8.2021.12.17.04.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 04:21:13 -0800 (PST) Message-ID: <80151bc1-bf1d-ea2f-aa95-9610e9130d20@palves.net> Date: Fri, 17 Dec 2021 12:21:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 04/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-catch-load.exp Content-Language: en-US To: Lancelot SIX References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-5-lsix@lancelotsix.com> <882b90a8-a819-4bd5-1e51-fa1cd408ed4d@palves.net> <20211216232711.oke7xqfsvfn44wk4@Plymouth> From: Pedro Alves In-Reply-To: <20211216232711.oke7xqfsvfn44wk4@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-16 23:27, Lancelot SIX wrote: > From 6fcb1d880bf5009aa9ce9e873a5c5f50e6fc142d Mon Sep 17 00:00:00 2001 > From: Lancelot SIX > Date: Mon, 22 Nov 2021 22:36:47 +0000 > Subject: [PATCH] gdb/testsuite: Remove duplicates from > gdb.mi/mi-catch-load.exp > > When I run the testsuite, I have: > > Running .../gdb/testsuite/gdb.mi/mi-catch-load.exp ... > DUPLICATE: gdb.mi/mi-catch-load.exp: breakpoint at main > DUPLICATE: gdb.mi/mi-catch-load.exp: mi runto main > > Fix by grouping the various phases in with_test_prefix blocks. Since > the tests now have a prefix, remove the manually written prefixes in > testnames. > > Also change some messages with the pattern "(timeout) $testname" into > "$estname (timeout)" since tools will handle this as $testname[1] (which > is what we want in this particular scenario). > > Tested on x86_64-linux. > > [1] https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages Perfect. This is OK.