Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp
Date: Fri, 10 Dec 2021 21:56:34 +0000	[thread overview]
Message-ID: <757f0aed-decd-ab44-619a-2e0d6df59cf1@palves.net> (raw)
In-Reply-To: <20211126230038.103225-12-lsix@lancelotsix.com>

On 2021-11-26 23:00, Lancelot SIX via Gdb-patches wrote:
>  mi_expect_stop "breakpoint-hit" .* {{name="inv",value="<optimized out>"}} .* .* {.* disp="keep"} "no: invalid: stop"
>  mi_gdb_test "-stack-list-variables --all-values" {\^done,variables=\[{name="inv",arg="1",value="<optimized out>"}\]} "no: invalid: -stack-list-variables"
>  
> -if {[mi_runto_main] == -1} {
> -    return -1
> +with_test_prefix "setup for set print-entry-values only" {
> +    if {[mi_runto_main] == -1} {
> +	return -1
> +    }
>  }
>  mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values"
>  mi_send_resuming_command "exec-continue" "only: entry_equal: continue"
> @@ -83,8 +87,10 @@ mi_send_resuming_command "exec-continue" "only: invalid: continue"

IWBN to get this grouped properly while at it.  Would you mind removing the "only:" etc.
manual prefixes instead, converting that to the with_test_prefix prefix?  Like:

with_test_prefix "only" {
    if {[mi_runto_main] == -1} {
	return -1
    }

-   mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values"
-   mi_send_resuming_command "exec-continue" "only: entry_equal: continue"
+  mi_gdb_test "-gdb-set print entry-values only" {\^done} "set print entry-values"
+  mi_send_resuming_command "exec-continue" "entry_equal: continue"
}

etc?

  reply	other threads:[~2021-12-10 21:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 23:00 [PATCH 00/12] Remove DUPLICATEs warnings Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 01/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-syn-frame.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 02/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nsthrexec.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 03/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-watch.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 04/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-catch-load.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55   ` Pedro Alves
2021-12-16 23:27     ` Lancelot SIX via Gdb-patches
2021-12-17 12:21       ` Pedro Alves
2021-11-26 23:00 ` [PATCH 05/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-child.exp Lancelot SIX via Gdb-patches
2021-12-10 21:55   ` Pedro Alves
2021-12-16 23:40     ` Lancelot SIX via Gdb-patches
2021-12-17 13:00       ` [PATCH] gdb/testsuite: Remove some duplication " Pedro Alves
2021-12-17 23:24         ` Lancelot SIX via Gdb-patches
2022-01-06 16:44           ` Pedro Alves
2021-11-26 23:00 ` [PATCH 06/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-var-child.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 07/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 08/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-nonstop-exit.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56   ` Pedro Alves
2021-12-16 23:48     ` Lancelot SIX via Gdb-patches
2021-12-17 13:52       ` Pedro Alves
2021-11-26 23:00 ` [PATCH 09/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-rtti.exp Lancelot SIX via Gdb-patches
2021-11-26 23:00 ` [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56   ` Pedro Alves
2021-12-16 23:59     ` Lancelot SIX via Gdb-patches
2021-12-17 13:53       ` Pedro Alves
2021-11-26 23:00 ` [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp Lancelot SIX via Gdb-patches
2021-12-10 21:56   ` Pedro Alves [this message]
2021-12-17 22:57     ` Lancelot SIX via Gdb-patches
2022-01-06 16:49       ` Pedro Alves
2021-11-26 23:00 ` [PATCH 12/12] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex Lancelot SIX via Gdb-patches
2021-12-09 18:15 ` [PATCH 00/12] Remove DUPLICATEs warnings Tom Tromey
2021-12-10 22:01 ` Pedro Alves
2022-01-07 22:43 ` Lancelot SIX via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=757f0aed-decd-ab44-619a-2e0d6df59cf1@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox