Re: [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp

[Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>]

On Fri, Dec 10, 2021 at 09:56:51PM +0000, Pedro Alves wrote:
> On 2021-11-26 23:00, Lancelot SIX via Gdb-patches wrote:
> > When running the testsuite, I have:
> > 
> >     Running .../gdb/testsuite/gdb.mi/mi-language.exp ...
> >     DUPLICATE: gdb.mi/mi-language.exp: set lang ada
> > 
> > Fix the erroneous test name.
> > 
> > Tested on x86_64-linux.
> > ---
> >  gdb/testsuite/gdb.mi/mi-language.exp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/gdb/testsuite/gdb.mi/mi-language.exp b/gdb/testsuite/gdb.mi/mi-language.exp
> > index d1e4503b6f9..a4e946e3789 100644
> > --- a/gdb/testsuite/gdb.mi/mi-language.exp
> > +++ b/gdb/testsuite/gdb.mi/mi-language.exp
> > @@ -45,7 +45,7 @@ mi_gdb_test "-data-evaluate-expression --language c \"sizeof (void*)\"" \
> >  # Double-check that the current language has not changed.
> >  mi_gdb_test "show lang ada" \
> >              ".*The current source language is \\\\\"ada\\\\\".*" \
> > -            "set lang ada"
> > +            "show lang ada"
> >  
> 
> FYI, you can also just remove the last argument, as it defaults to the command string.
> Less duplication that way.

Done.

Thanks for the review.

Lancelot

---
From da0cd214af2e410e1994cfa9f3b7f4d99e768d09 Mon Sep 17 00:00:00 2001
From: Lancelot SIX <lsix@lancelotsix.com>
Date: Tue, 23 Nov 2021 15:15:57 +0000
Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp

When running the testsuite, I have:

    Running .../gdb/testsuite/gdb.mi/mi-language.exp ...
    DUPLICATE: gdb.mi/mi-language.exp: set lang ada

This is due to an erroneous explicit test name.  This explicit test name
also happens to be useless (at least it would have been if it was
correct) since it only repeats the command, so just remove the explicit
test name and let the command be used as default test name.  Also remove
explicit test name at another location in the file since it also just
repeat the command.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.mi/mi-language.exp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-language.exp b/gdb/testsuite/gdb.mi/mi-language.exp
index d1e4503b6f9..c98eb0a8142 100644
--- a/gdb/testsuite/gdb.mi/mi-language.exp
+++ b/gdb/testsuite/gdb.mi/mi-language.exp
@@ -28,8 +28,7 @@ mi_gdb_test "-list-features" \
             "-list-features should include \"language-option\""
 
 mi_gdb_test "set lang ada" \
-            ".*=cmd-param-changed,param=\"language\",value=\"ada\".*" \
-            "set lang ada"
+            ".*=cmd-param-changed,param=\"language\",value=\"ada\".*"
 
 # Evaluate an expression that the Ada language is unable to parse.
 mi_gdb_test "-data-evaluate-expression \"sizeof (void*)\"" \
@@ -44,8 +43,7 @@ mi_gdb_test "-data-evaluate-expression --language c \"sizeof (void*)\"" \
 
 # Double-check that the current language has not changed.
 mi_gdb_test "show lang ada" \
-            ".*The current source language is \\\\\"ada\\\\\".*" \
-            "set lang ada"
+            ".*The current source language is \\\\\"ada\\\\\".*"
 
 # Test what happens when specifying an invalid language name...
 mi_gdb_test "-data-evaluate-expression --language invlang \"sizeof (void*)\"" \
-- 
2.34.0