From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KdGsASfTu2F4bwAAWB0awg (envelope-from ) for ; Thu, 16 Dec 2021 19:00:39 -0500 Received: by simark.ca (Postfix, from userid 112) id E6ECC1F0BD; Thu, 16 Dec 2021 19:00:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 210C61E940 for ; Thu, 16 Dec 2021 19:00:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6659D3858415 for ; Fri, 17 Dec 2021 00:00:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6659D3858415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639699237; bh=WRr4SFozUAiaPWmGNZ8phAarprpjqnElXQjgWXaC2gM=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rz0epkOauFA7Jv67HO/rTpZP+6oD1nICPTgnZkUgU9GbIsYwgQskBzVcsXC3XXTLo AFS2e96fGz09I4tzR+Jq8jKyk2MdbG5Mx8fvmhlCpGulUBRVCbPxSOU7eO0jxX0vOC pU1oLUfgXqdZq0tQ3UOWfIdlusEja2aoDDoL7WO8= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 6A2DE385841F for ; Thu, 16 Dec 2021 23:59:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A2DE385841F Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:7c27:fcf5:8e6d:c1bd]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 9D7E880D5D; Thu, 16 Dec 2021 23:59:46 +0000 (UTC) Date: Thu, 16 Dec 2021 23:59:43 +0000 To: Pedro Alves Subject: Re: [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp Message-ID: <20211216235943.e7bofy6q7yja4wgf@Plymouth> References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-11-lsix@lancelotsix.com> <4a9abcaf-c1e5-99a2-5c52-54a260769d08@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a9abcaf-c1e5-99a2-5c52-54a260769d08@palves.net> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 16 Dec 2021 23:59:46 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, Dec 10, 2021 at 09:56:51PM +0000, Pedro Alves wrote: > On 2021-11-26 23:00, Lancelot SIX via Gdb-patches wrote: > > When running the testsuite, I have: > > > > Running .../gdb/testsuite/gdb.mi/mi-language.exp ... > > DUPLICATE: gdb.mi/mi-language.exp: set lang ada > > > > Fix the erroneous test name. > > > > Tested on x86_64-linux. > > --- > > gdb/testsuite/gdb.mi/mi-language.exp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gdb/testsuite/gdb.mi/mi-language.exp b/gdb/testsuite/gdb.mi/mi-language.exp > > index d1e4503b6f9..a4e946e3789 100644 > > --- a/gdb/testsuite/gdb.mi/mi-language.exp > > +++ b/gdb/testsuite/gdb.mi/mi-language.exp > > @@ -45,7 +45,7 @@ mi_gdb_test "-data-evaluate-expression --language c \"sizeof (void*)\"" \ > > # Double-check that the current language has not changed. > > mi_gdb_test "show lang ada" \ > > ".*The current source language is \\\\\"ada\\\\\".*" \ > > - "set lang ada" > > + "show lang ada" > > > > FYI, you can also just remove the last argument, as it defaults to the command string. > Less duplication that way. Done. Thanks for the review. Lancelot --- >From da0cd214af2e410e1994cfa9f3b7f4d99e768d09 Mon Sep 17 00:00:00 2001 From: Lancelot SIX Date: Tue, 23 Nov 2021 15:15:57 +0000 Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp When running the testsuite, I have: Running .../gdb/testsuite/gdb.mi/mi-language.exp ... DUPLICATE: gdb.mi/mi-language.exp: set lang ada This is due to an erroneous explicit test name. This explicit test name also happens to be useless (at least it would have been if it was correct) since it only repeats the command, so just remove the explicit test name and let the command be used as default test name. Also remove explicit test name at another location in the file since it also just repeat the command. Tested on x86_64-linux. --- gdb/testsuite/gdb.mi/mi-language.exp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-language.exp b/gdb/testsuite/gdb.mi/mi-language.exp index d1e4503b6f9..c98eb0a8142 100644 --- a/gdb/testsuite/gdb.mi/mi-language.exp +++ b/gdb/testsuite/gdb.mi/mi-language.exp @@ -28,8 +28,7 @@ mi_gdb_test "-list-features" \ "-list-features should include \"language-option\"" mi_gdb_test "set lang ada" \ - ".*=cmd-param-changed,param=\"language\",value=\"ada\".*" \ - "set lang ada" + ".*=cmd-param-changed,param=\"language\",value=\"ada\".*" # Evaluate an expression that the Ada language is unable to parse. mi_gdb_test "-data-evaluate-expression \"sizeof (void*)\"" \ @@ -44,8 +43,7 @@ mi_gdb_test "-data-evaluate-expression --language c \"sizeof (void*)\"" \ # Double-check that the current language has not changed. mi_gdb_test "show lang ada" \ - ".*The current source language is \\\\\"ada\\\\\".*" \ - "set lang ada" + ".*The current source language is \\\\\"ada\\\\\".*" # Test what happens when specifying an invalid language name... mi_gdb_test "-data-evaluate-expression --language invlang \"sizeof (void*)\"" \ -- 2.34.0