From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9ekFIWkc12FkBgAAWB0awg (envelope-from ) for ; Thu, 06 Jan 2022 11:44:25 -0500 Received: by simark.ca (Postfix, from userid 112) id 6F5B01EE22; Thu, 6 Jan 2022 11:44:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A48911EA69 for ; Thu, 6 Jan 2022 11:44:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F256C3857C43 for ; Thu, 6 Jan 2022 16:44:23 +0000 (GMT) Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id D5D9C3858408 for ; Thu, 6 Jan 2022 16:44:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5D9C3858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 34DC3861440; Thu, 6 Jan 2022 16:44:09 +0000 (UTC) Received: from pdx1-sub0-mail-a244.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AF2F186101F; Thu, 6 Jan 2022 16:44:08 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from pdx1-sub0-mail-a244.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.114.196.217 (trex/6.4.3); Thu, 06 Jan 2022 16:44:09 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Celery-Callous: 1cbf9b4b3802df58_1641487448964_2728557877 X-MC-Loop-Signature: 1641487448964:4090219948 X-MC-Ingress-Time: 1641487448963 Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt [2.83.100.144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a244.dreamhost.com (Postfix) with ESMTPSA id 4JVByH6lrkz1Rn; Thu, 6 Jan 2022 08:44:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=palves.net; s=palves.net; t=1641487448; bh=ik1n0iearX3Re5UZXxKGAczv/IM=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=KnCwOb1HqKcZ4NT7aRl4a43sHeN2zGPZoiVvHk2HMux/WaYXoFy8ttYZHUOtsyYgA LNdn344L3N3MUUsHXjf67NQseNqkxkYFpXs+vw5vyBstikuwSsW7ZPKiJVS2GH2LS6 xIoqCCAFO/YilEjpYZHQh+mhN7DPagrIB8C+Qcdw= Message-ID: <844a86c1-9418-0e38-180a-1e6727c66383@palves.net> Date: Thu, 6 Jan 2022 16:44:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH] gdb/testsuite: Remove some duplication from gdb.mi/mi-var-child.exp Content-Language: en-US To: Lancelot SIX References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-6-lsix@lancelotsix.com> <20211216234049.zendtecxswjceyki@Plymouth> <55e612b6-645a-b044-da7c-a2ee48298de0@palves.net> <20211217232439.urx6zd2egmwntmje@Plymouth> From: Pedro Alves In-Reply-To: <20211217232439.urx6zd2egmwntmje@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-17 23:24, Lancelot SIX wrote: >> That is certainly fine. Please go ahead with what you had. >> >> I gave it another look, and noticed that at least the "get number of children" tests >> can be easily factored out, like below. This applies on top of your patch. >> >> WDYT? >> > > Nice! > > I was expecting something similar could be done, but I did not pushed to > do it. It looks good, and I confirm that I have no difference in the > .sum file. > > I am confident this is OK, and I have integrated this patch in my > branch. If this is OK, I'll push with the rest of my series. Sorry, missed this question before. Yes, this is totally fine, and actually less work for me, so thanks. :-)