Re: [review v6] [Debugging output] Make remote packet truncation length adjustable

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 25 Nov 2019 08:30:57 -0500
> From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
> ......................................................................
> 
> [Debugging output] Make remote packet truncation length adjustable
> 
> While debugging, i felt the need to adjust the truncation length of remote
> packets so i could see more or less data as needed. The default is currently
> set to 512 bytes.
> 
> This patch makes this option adjustable through the new "set debug
> remote-packet-max-chars" command. It can be set to unlimited if we want to
> completely disable truncation.
> 
> Update on v5:
> 
> - Adjusted function and variable documentation, NEWS entry and GDB manual.
> 
> gdb/ChangeLog:
> 
> 2019-11-25  Luis Machado  <luis.machado@linaro.org>
> 
> 	* NEWS (New Commands): Mention "set debug remote-packet-max-chars".
> 	* remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
> 	(remote_packet_max_chars): New static global.
> 	(show_remote_packet_max_chars): New function.
> 	(remote_target::putpkt_binary): Adjust to use new
> 	remote_packet_max_chars option.
> 	(remote_target::getpkt_or_notif_sane_1): Likewise.
> 	(_initialize_remote): Register new remote-packet-max-chars option.
> 
> gdb/doc/ChangeLog:
> 
> 2019-11-25  Luis Machado  <luis.machado@linaro.org>
> 
> 	* gdb.texinfo (Debugging Output): Document set debug
> 	remote-packet-max-chars.

OK for the documentation parts.

Thanks.