[review v2] [Debugging output] Make remote packet truncation length adjustable

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Thank you.  I have a small suggestion for the docs, but otherwise
everything looks good.

I'm marking this +1 since Eli should review the doc changes.

| --- gdb/doc/gdb.texinfo
| +++ gdb/doc/gdb.texinfo
| @@ -26273,7 +26273,20 @@ the serial line to the remote machine.  The info is printed on the
|  @value{GDBN} standard output stream. The default is off.
|  @item show debug remote
|  Displays the state of display of remote packets.
|  
| +@item set debug remote-log-length
| +Sets the number of characters to display for each remote packet when
| +@code{set debug remote} is on. This is useful to prevent GDB from
| +displaying lengthy remote packets and polluting the console.
| +
| +The default value is @code{512}, which means @value{GDBN} will truncate the
| +remote packet output after 512 bytes.

PS2, Line 26283:

I think maybe this should say something like "will truncate each
remote packet after 512 bytes" ... the current text makes it sound
a bit like the entirety of the output will be truncated.

| +
| +Setting this option to @code{unlimited} will disable truncation and will output
| +the full length of the remote packets.
| +@item show debug remote-log-length
| +Displays the number of bytes to output for remote packet debugging.
| +
|  @item set debug separate-debug-file
|  Turns on or off display of debug output about separate debug file search.
|  @item show debug separate-debug-file

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 21 Nov 2019 14:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment