From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>, Tom Tromey <tromey@sourceware.org>
Subject: [review v6] [Debugging output] Make remote packet truncation length adjustable
Date: Mon, 25 Nov 2019 13:33:00 -0000 [thread overview]
Message-ID: <20191125133303.70C5220AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574263562000.I2e871b37bfcaa6376537c3fe3db8f016dd806a7c@gnutoolchain-gerrit.osci.io>
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................
Patch Set 6:
(1 comment)
Thanks for the review. I'll push this later today.
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +23,19 @@ gdb/ChangeLog:
| +2019-11-21 Luis Machado <luis.machado@linaro.org>
| +
| + * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
| + * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
| + (remote_packet_max_chars): New static global.
| + (show_remote_packet_max_chars): New function.
| + (remote_target::putpkt_binary): Adjust to use new
| + remote-packet-max-chars option.
| + (remote_target::getpkt_or_notif_sane_1): Likewise.
| + (_initialize_remote): Register new remote_packet_max_chars option.
PS5, Line 32:
Ah, got it. Sorry, i missed this in e-mail form for some reason.
| +
| +gdb/doc/ChangeLog:
| +
| +2019-11-21 Luis Machado <luis.machado@linaro.org>
| +
| + * gdb.texinfo (Debugging Output): Document set debug
| + remote-packet-max-chars.
| +
| +Signed-off-by: Luis Machado <luis.machado@linaro.org>
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 6
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 25 Nov 2019 13:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-25 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 15:26 [review] " Luis Machado (Code Review)
2019-11-20 15:27 ` Luis Machado (Code Review)
2019-11-20 18:12 ` Tom Tromey (Code Review)
2019-11-20 18:42 ` Luis Machado (Code Review)
2019-11-20 20:35 ` [review v2] " Luis Machado (Code Review)
2019-11-21 15:05 ` Eli Zaretskii
2019-11-21 14:41 ` Tom Tromey (Code Review)
2019-11-21 15:17 ` [review v3] " Luis Machado (Code Review)
2019-11-21 15:25 ` Eli Zaretskii
2019-11-21 16:31 ` Pedro Alves (Code Review)
2019-11-21 17:15 ` [review v4] " Luis Machado (Code Review)
2019-11-21 18:55 ` Pedro Alves (Code Review)
2019-11-21 21:49 ` Luis Machado (Code Review)
2019-11-21 21:49 ` Luis Machado (Code Review)
2019-11-21 22:03 ` [review v5] " Luis Machado (Code Review)
2019-11-22 7:34 ` Eli Zaretskii
2019-11-22 15:22 ` Pedro Alves (Code Review)
2019-11-25 13:31 ` [review v6] " Luis Machado (Code Review)
2019-11-25 15:34 ` Eli Zaretskii
2019-11-25 13:33 ` Luis Machado (Code Review) [this message]
2019-11-25 15:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-25 15:30 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125133303.70C5220AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=palves@redhat.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox