From: Eli Zaretskii <eliz@gnu.org>
To: luis.machado@linaro.org, tromey@sourceware.org,
gdb-patches@sourceware.org
Subject: Re: [review v3] [Debugging output] Make remote packet truncation length adjustable
Date: Thu, 21 Nov 2019 15:25:00 -0000 [thread overview]
Message-ID: <83k17txndp.fsf@gnu.org> (raw)
In-Reply-To: <20191121151736.9169C2816F@gnutoolchain-gerrit.osci.io>
> Date: Thu, 21 Nov 2019 10:17:36 -0500
> From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>
> This patch makes this option adjustable through the new "set debug
> remote-log-length" command. It can be set to unlimited if we want to
> completely disable truncation.
>
> gdb/ChangeLog:
>
> 2019-11-21 Luis Machado <luis.machado@linaro.org>
>
> * NEWS (New Commands): Mention "set debug remote-log-length".
> * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
> (debug_remote_log_length): New static global.
> (show_debug_remote_log_length): New function.
> (remote_target::putpkt_binary): Adjust to use new
> debug_remote_log_length option.
> (remote_target::getpkt_or_notif_sane_1): Likewise.
> (_initialize_remote): Register new remote-log-length option.
>
> gdb/doc/ChangeLog:
>
> 2019-11-21 Luis Machado <luis.machado@linaro.org>
>
> * gdb.texinfo (Debugging Output): Document set debug remote-log-length.
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2019-11-21 15:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 15:26 [review] " Luis Machado (Code Review)
2019-11-20 15:27 ` Luis Machado (Code Review)
2019-11-20 18:12 ` Tom Tromey (Code Review)
2019-11-20 18:42 ` Luis Machado (Code Review)
2019-11-20 20:35 ` [review v2] " Luis Machado (Code Review)
2019-11-21 15:05 ` Eli Zaretskii
2019-11-21 14:41 ` Tom Tromey (Code Review)
2019-11-21 15:17 ` [review v3] " Luis Machado (Code Review)
2019-11-21 15:25 ` Eli Zaretskii [this message]
2019-11-21 16:31 ` Pedro Alves (Code Review)
2019-11-21 17:15 ` [review v4] " Luis Machado (Code Review)
2019-11-21 18:55 ` Pedro Alves (Code Review)
2019-11-21 21:49 ` Luis Machado (Code Review)
2019-11-21 21:49 ` Luis Machado (Code Review)
2019-11-21 22:03 ` [review v5] " Luis Machado (Code Review)
2019-11-22 7:34 ` Eli Zaretskii
2019-11-22 15:22 ` Pedro Alves (Code Review)
2019-11-25 13:31 ` [review v6] " Luis Machado (Code Review)
2019-11-25 15:34 ` Eli Zaretskii
2019-11-25 13:33 ` Luis Machado (Code Review)
2019-11-25 15:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-25 15:30 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k17txndp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox