From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29580 invoked by alias); 25 Nov 2019 13:33:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29567 invoked by uid 89); 25 Nov 2019 13:33:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=sk:comment, sk:Comment X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 13:33:06 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 99B2B20484; Mon, 25 Nov 2019 08:33:04 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 87DEB202DF; Mon, 25 Nov 2019 08:33:03 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 70C5220AF6; Mon, 25 Nov 2019 08:33:03 -0500 (EST) X-Gerrit-PatchSet: 6 Date: Mon, 25 Nov 2019 13:33:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v6] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: 03b2aeabe84fdbfbda7980e80ec58ac591e27fe8 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 25 Nov 2019 08:33:02 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191125133303.70C5220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00825.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 6: (1 comment) Thanks for the review. I'll push this later today. | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +23,19 @@ gdb/ChangeLog: | +2019-11-21 Luis Machado | + | + * NEWS (New Commands): Mention "set debug remote-packet-max-chars". | + * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove. | + (remote_packet_max_chars): New static global. | + (show_remote_packet_max_chars): New function. | + (remote_target::putpkt_binary): Adjust to use new | + remote-packet-max-chars option. | + (remote_target::getpkt_or_notif_sane_1): Likewise. | + (_initialize_remote): Register new remote_packet_max_chars option. PS5, Line 32: Ah, got it. Sorry, i missed this in e-mail form for some reason. | + | +gdb/doc/ChangeLog: | + | +2019-11-21 Luis Machado | + | + * gdb.texinfo (Debugging Output): Document set debug | + remote-packet-max-chars. | + | +Signed-off-by: Luis Machado -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 6 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Mon, 25 Nov 2019 13:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment