From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99651 invoked by alias); 21 Nov 2019 14:41:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99641 invoked by uid 89); 21 Nov 2019 14:41:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=serial X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2019 14:41:10 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 26AE52030C; Thu, 21 Nov 2019 09:41:08 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id F39CC20249; Thu, 21 Nov 2019 09:41:03 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id BB8F42816F; Thu, 21 Nov 2019 09:41:03 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Thu, 21 Nov 2019 14:41:00 -0000 From: "Tom Tromey (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4ca2d5804794cd788817b1e004c54f6ded37bbcb In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 21 Nov 2019 09:41:02 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191121144103.BB8F42816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00652.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thank you. I have a small suggestion for the docs, but otherwise everything looks good. I'm marking this +1 since Eli should review the doc changes. | --- gdb/doc/gdb.texinfo | +++ gdb/doc/gdb.texinfo | @@ -26273,7 +26273,20 @@ the serial line to the remote machine. The info is printed on the | @value{GDBN} standard output stream. The default is off. | @item show debug remote | Displays the state of display of remote packets. | | +@item set debug remote-log-length | +Sets the number of characters to display for each remote packet when | +@code{set debug remote} is on. This is useful to prevent GDB from | +displaying lengthy remote packets and polluting the console. | + | +The default value is @code{512}, which means @value{GDBN} will truncate the | +remote packet output after 512 bytes. PS2, Line 26283: I think maybe this should say something like "will truncate each remote packet after 512 bytes" ... the current text makes it sound a bit like the entirety of the output will be truncated. | + | +Setting this option to @code{unlimited} will disable truncation and will output | +the full length of the remote packets. | +@item show debug remote-log-length | +Displays the number of bytes to output for remote packet debugging. | + | @item set debug separate-debug-file | Turns on or off display of debug output about separate debug file search. | @item show debug separate-debug-file -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 2 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Thu, 21 Nov 2019 14:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment