From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26816 invoked by alias); 25 Nov 2019 15:34:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26801 invoked by uid 89); 25 Nov 2019 15:34:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Review, gerrit@gnutoolchain-gerrit.osci.io, U*gerrit, sk:gerrit@ X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 15:34:52 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZGO2-0006Xi-E8; Mon, 25 Nov 2019 10:34:50 -0500 Received: from [176.228.60.248] (port=3755 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZGO0-0005FL-TB; Mon, 25 Nov 2019 10:34:50 -0500 Date: Mon, 25 Nov 2019 15:34:00 -0000 Message-Id: <83r21wrmuc.fsf@gnu.org> From: Eli Zaretskii To: luis.machado@linaro.org, tromey@sourceware.org, palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <20191125133058.114F720AF6@gnutoolchain-gerrit.osci.io> Subject: Re: [review v6] [Debugging output] Make remote packet truncation length adjustable References: <20191125133058.114F720AF6@gnutoolchain-gerrit.osci.io> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00830.txt.bz2 > Date: Mon, 25 Nov 2019 08:30:57 -0500 > From: "Luis Machado (Code Review)" > > Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 > ...................................................................... > > [Debugging output] Make remote packet truncation length adjustable > > While debugging, i felt the need to adjust the truncation length of remote > packets so i could see more or less data as needed. The default is currently > set to 512 bytes. > > This patch makes this option adjustable through the new "set debug > remote-packet-max-chars" command. It can be set to unlimited if we want to > completely disable truncation. > > Update on v5: > > - Adjusted function and variable documentation, NEWS entry and GDB manual. > > gdb/ChangeLog: > > 2019-11-25 Luis Machado > > * NEWS (New Commands): Mention "set debug remote-packet-max-chars". > * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove. > (remote_packet_max_chars): New static global. > (show_remote_packet_max_chars): New function. > (remote_target::putpkt_binary): Adjust to use new > remote_packet_max_chars option. > (remote_target::getpkt_or_notif_sane_1): Likewise. > (_initialize_remote): Register new remote-packet-max-chars option. > > gdb/doc/ChangeLog: > > 2019-11-25 Luis Machado > > * gdb.texinfo (Debugging Output): Document set debug > remote-packet-max-chars. OK for the documentation parts. Thanks.