From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "PC register is not available" issue
Date: Fri, 28 Mar 2014 17:29:00 -0000 [thread overview]
Message-ID: <83d2h6fczk.fsf@gnu.org> (raw)
In-Reply-To: <20140328125955.GC4030@adacore.com>
> Date: Fri, 28 Mar 2014 05:59:55 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: palves@redhat.com, gdb-patches@sourceware.org
>
> > + if (killed)
> > + SetThreadContext (th->h, &th->context);
> > + else
> > + CHECK (SetThreadContext (th->h, &th->context));
>
> Rather than duplicate the call to SetThreadContext, perhaps
> another way of doing it would be:
>
> DWORD status;
>
> status = SetThreadContext (th->h, &th->context);
> if (!killed)
> CHECK (status)
Fine with me.
next prev parent reply other threads:[~2014-03-28 17:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 19:43 Eli Zaretskii
2014-03-18 16:16 ` Joel Brobecker
2014-03-18 16:35 ` Eli Zaretskii
2014-03-18 16:54 ` Joel Brobecker
2014-03-18 17:13 ` Eli Zaretskii
2014-03-18 17:33 ` Pedro Alves
2014-03-19 3:41 ` Eli Zaretskii
2014-03-19 10:07 ` Pedro Alves
2014-03-19 16:24 ` Eli Zaretskii
2014-03-19 16:41 ` Pedro Alves
2014-03-26 18:49 ` Eli Zaretskii
2014-03-27 12:56 ` Joel Brobecker
2014-03-27 17:41 ` Eli Zaretskii
2014-03-28 13:00 ` Joel Brobecker
2014-03-28 17:29 ` Eli Zaretskii [this message]
2014-03-28 14:50 ` Pedro Alves
2014-03-28 17:35 ` Eli Zaretskii
2014-03-28 17:49 ` Pedro Alves
2014-03-28 18:30 ` Eli Zaretskii
2014-03-31 15:31 ` Eli Zaretskii
2014-04-05 9:06 ` Eli Zaretskii
2014-04-07 16:58 ` Joel Brobecker
2014-04-07 17:09 ` Pedro Alves
2014-04-07 18:25 ` Eli Zaretskii
2014-04-07 21:39 ` Joel Brobecker
2014-04-08 2:44 ` Eli Zaretskii
2014-04-08 4:23 ` Joel Brobecker
2014-04-08 15:17 ` Eli Zaretskii
2014-04-08 11:32 ` Pedro Alves
2014-04-08 16:43 ` Pedro Alves
2014-04-08 17:10 ` Eli Zaretskii
2014-04-08 17:36 ` Pedro Alves
2014-04-08 17:54 ` Eli Zaretskii
2014-04-11 20:06 ` Joel Brobecker
2014-04-19 8:33 ` Eli Zaretskii
2014-04-21 15:43 ` Joel Brobecker
2014-04-21 15:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d2h6fczk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox