From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111467-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10112 invoked by alias); 28 Mar 2014 17:29:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10101 invoked by uid 89); 28 Mar 2014 17:29:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout27.012.net.il
Received: from mtaout27.012.net.il (HELO mtaout27.012.net.il) (80.179.55.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Mar 2014 17:29:35 +0000
Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N3500500PPOAF00@mtaout27.012.net.il> for gdb-patches@sourceware.org; Fri, 28 Mar 2014 20:26:39 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3500PYLPSF4N40@mtaout27.012.net.il>; Fri, 28 Mar 2014 20:26:39 +0300 (IDT)
Date: Fri, 28 Mar 2014 17:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Fix "PC register is not available" issue
In-reply-to: <20140328125955.GC4030@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d2h6fczk.fsf@gnu.org>
References: <83txawa9wk.fsf@gnu.org> <20140318161608.GD4282@adacore.com> <83pplja2h9.fsf@gnu.org> <20140318165413.GE4282@adacore.com> <834n2kztfw.fsf@gnu.org> <20140327125646.GA4030@adacore.com> <83k3bfy1ws.fsf@gnu.org> <20140328125955.GC4030@adacore.com>
X-IsSubscribed: yes
X-SW-Source: 2014-03/txt/msg00665.txt.bz2

> Date: Fri, 28 Mar 2014 05:59:55 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: palves@redhat.com, gdb-patches@sourceware.org
> 
> > +             if (killed)
> > +               SetThreadContext (th->h, &th->context);
> > +             else
> > +               CHECK (SetThreadContext (th->h, &th->context));
> 
> Rather than duplicate the call to SetThreadContext, perhaps
> another way of doing it would be:
> 
>     DWORD status;
> 
>     status = SetThreadContext (th->h, &th->context);
>     if (!killed)
>       CHECK (status)

Fine with me.