From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "PC register is not available" issue
Date: Mon, 07 Apr 2014 17:09:00 -0000 [thread overview]
Message-ID: <5342DBBC.4090500@redhat.com> (raw)
In-Reply-To: <83ioqucrkw.fsf@gnu.org>
On 03/31/2014 04:31 PM, Eli Zaretskii wrote:
>> Date: Fri, 28 Mar 2014 21:30:10 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: brobecker@adacore.com, gdb-patches@sourceware.org
>>
>>> Date: Fri, 28 Mar 2014 17:49:13 +0000
>>> From: Pedro Alves <palves@redhat.com>
>>> CC: brobecker@adacore.com, gdb-patches@sourceware.org
>>>
>>>>> Why bother calling SetThreadContext at all if we just killed
>>>>> the process?
>>>>
>>>> See my other mail and Joel's response.
>>>
>>> Not sure what you mean. TerminateProcess is asynchronous, and
>>> we need to resume the inferior and collect the debug events
>>> until we see the process terminate. But, my question is
>>> why would we write the thread's registers at all if we
>>> just told it to die? Seems to be we could just skip
>>> calling SetThreadContext instead of calling it but
>>> ignoring the result.
>>
>> If you say so, I don't know enough about this stuff.
>
> Actually, upon second thought: we continue the inferior after
> TerminateProcess call to let it be killed, right? If so, shouldn't we
> continue it with the right context?
I don't think the threads are going to run whatever context
you set them them to. They'll surely die before ever getting
scheduled to run any further userspace code?
>
>>>>> Sounds like GDBserver might have this problem too.
>>>>
>>>> If there's an easy way to verify that, without having 2 systems
>>>> talking via some communications line, please tell how, and I will try
>>>> that.
>>>
>>> Sure, you can run gdbserver and gdb on the same machine, and connect
>>> with tcp. Just:
>>>
>>> $ gdbserver :9999 myprogram.exe
>>>
>>> in one terminal, and:
>>>
>>> $ gdb myprogram.exe -ex "tar rem :9999" -ex "b main" -ex "c"
>>>
>>> in another.
>>
>> OK, will try that.
>
> Funnily enough, I cannot get GDBserver to emit similar warnings in the
> same situation. I don't understand the reasons for that, since the
> code is very similar, and with a single exception, we do check the
> return values of calls to GetThreadContext, SetThreadContext, and
> SuspendThread in GDBserver. But the fact remains that no warnings
> about these threads are ever seen when debugging remotely. I do see
> the extra threads under GDBserver as well.
GDBserver's warnings are guarded by 'if (debug_threads)' (see OUTMSG2).
That means you'll need to start gdbserver with --debug to see them.
Did you do that?
--
Pedro Alves
next prev parent reply other threads:[~2014-04-07 17:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 19:43 Eli Zaretskii
2014-03-18 16:16 ` Joel Brobecker
2014-03-18 16:35 ` Eli Zaretskii
2014-03-18 16:54 ` Joel Brobecker
2014-03-18 17:13 ` Eli Zaretskii
2014-03-18 17:33 ` Pedro Alves
2014-03-19 3:41 ` Eli Zaretskii
2014-03-19 10:07 ` Pedro Alves
2014-03-19 16:24 ` Eli Zaretskii
2014-03-19 16:41 ` Pedro Alves
2014-03-26 18:49 ` Eli Zaretskii
2014-03-27 12:56 ` Joel Brobecker
2014-03-27 17:41 ` Eli Zaretskii
2014-03-28 13:00 ` Joel Brobecker
2014-03-28 17:29 ` Eli Zaretskii
2014-03-28 14:50 ` Pedro Alves
2014-03-28 17:35 ` Eli Zaretskii
2014-03-28 17:49 ` Pedro Alves
2014-03-28 18:30 ` Eli Zaretskii
2014-03-31 15:31 ` Eli Zaretskii
2014-04-05 9:06 ` Eli Zaretskii
2014-04-07 16:58 ` Joel Brobecker
2014-04-07 17:09 ` Pedro Alves [this message]
2014-04-07 18:25 ` Eli Zaretskii
2014-04-07 21:39 ` Joel Brobecker
2014-04-08 2:44 ` Eli Zaretskii
2014-04-08 4:23 ` Joel Brobecker
2014-04-08 15:17 ` Eli Zaretskii
2014-04-08 11:32 ` Pedro Alves
2014-04-08 16:43 ` Pedro Alves
2014-04-08 17:10 ` Eli Zaretskii
2014-04-08 17:36 ` Pedro Alves
2014-04-08 17:54 ` Eli Zaretskii
2014-04-11 20:06 ` Joel Brobecker
2014-04-19 8:33 ` Eli Zaretskii
2014-04-21 15:43 ` Joel Brobecker
2014-04-21 15:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5342DBBC.4090500@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox