Re: [PATCHv2 4/5] gdb/mi: add new --group-by-objfile flag for -file-list-exec-source-files

[Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 19 May 2021 12:12:41 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index aae0d5b025a..77dd2fac082 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -46,7 +46,9 @@
>      all locations of the selected breakpoint.  This is equivalent to
>      the '-force' flag of the CLI's "cond" command.
>  
> - ** '-file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]'
> + ** '-file-list-exec-source-files [--group-by-objfile]
> + 	                          [--basename | --dirname]
> +                                  [--] [REGEXP]'
>  
>      The existing -file-list-exec-source-files command now takes an
>      optional REGEXP which is used to filter the source files that are
> @@ -56,6 +58,11 @@
>      When one of --basename or --dirname is given then REGEXP is only
>      matched against the specified part of the full source filename.
>  
> +    When the optional --group-by-objfile flag is used the output
> +    format is changed, the results are now a list of object files
> +    (executable and libraries) with the source files that are
> +    associated with each object file.
> +
>      The results from -file-list-exec-source-files now include a
>      'debug-fully-read' field which takes the value 'true' or 'false'.
>      A 'true' value indicates the source file is from a compilation

This part is OK.

> +If @code{--group-by-objfile} is used then the format of the results is
> +changed.  The results will now be a list of tuples, with each tuple
> +representing an object file (executable or shared libraries) loaded
                                                     ^^^^^^^^^
"library", in singular.  Other than that, the patch for the manual is
also OK.

Thanks.