Re: PING! Re: [PATCHv3 0/5] "info sources" - group by objfile

[Andrew Burgess <andrew.burgess@embecosm.com>]

* Andrew Burgess <andrew.burgess@embecosm.com> [2021-06-21 13:02:01 +0100]:

> I plan to push v3 later this week.

I've now pushed this series.

Thanks,
Andrew


> 
> The first two versions of this patch have had no negative feedback,
> and the changes in v3 are minor over v2.
> 
> Thanks,
> Andrew
> 
> 
> * Andrew Burgess <andrew.burgess@embecosm.com> [2021-06-07 19:32:22 +0100]:
> 
> > In V3:
> > 
> >  - 'info sources' now indicates when an objfile has no debug
> >    information at all, this is a slight change of code, and an update
> >    to the commit message in patch #5.
> > 
> >  - the MI output is updated to include the same information, there are
> >    code changes, an update of the commit message, and changes to the
> >    documentation in patch #4.
> > 
> >  - all the other patches are unchanged.
> > 
> > Thanks,
> > Andrew
> > 
> > 
> > ---
> > 
> > Andrew Burgess (5):
> >   gdb: add new function quick_symbol_functions::has_unexpanded_symbols
> >   gdb: make struct output_source_filename_data more C++ like
> >   gdb/mi: add regexp filtering to -file-list-exec-source-files
> >   gdb/mi: add new --group-by-objfile flag for
> >     -file-list-exec-source-files
> >   gdb: change info sources to group results by objfile
> > 
> >  gdb/ChangeLog                                 | 111 ++++++
> >  gdb/NEWS                                      |  31 ++
> >  gdb/doc/ChangeLog                             |  15 +
> >  gdb/doc/gdb.texinfo                           | 176 +++++++--
> >  gdb/dwarf2/read.c                             |  22 ++
> >  gdb/mi/mi-cmd-file.c                          |  92 +++--
> >  gdb/objfiles.h                                |   6 +
> >  gdb/psympriv.h                                |   2 +
> >  gdb/psymtab.c                                 |  18 +
> >  gdb/quick-symbol.h                            |   6 +
> >  gdb/symfile-debug.c                           |  25 ++
> >  gdb/symtab.c                                  | 364 ++++++++++++------
> >  gdb/symtab.h                                  |  59 +++
> >  gdb/testsuite/ChangeLog                       |  19 +
> >  .../gdb.base/info_sources_2-header.h          |  28 ++
> >  gdb/testsuite/gdb.base/info_sources_2-lib.c   |  25 ++
> >  gdb/testsuite/gdb.base/info_sources_2-test.c  |  26 ++
> >  gdb/testsuite/gdb.base/info_sources_2.exp     | 169 ++++++++
> >  gdb/testsuite/gdb.dwarf2/dw2-filename.exp     |   2 +-
> >  gdb/testsuite/gdb.mi/mi-file.exp              |   2 +-
> >  gdb/testsuite/gdb.mi/mi-info-sources-base.c   |  23 ++
> >  gdb/testsuite/gdb.mi/mi-info-sources.c        |  25 ++
> >  gdb/testsuite/gdb.mi/mi-info-sources.exp      | 184 +++++++++
> >  23 files changed, 1239 insertions(+), 191 deletions(-)
> >  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h
> >  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c
> >  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c
> >  create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp
> >  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c
> >  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c
> >  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp
> > 
> > -- 
> > 2.25.4
> >