Re: [PATCHv2 0/5] "info sources" - group by objfile

[Andrew Burgess <andrew.burgess@embecosm.com>]

Ping!

Any thoughts on the new approach?  Specifically, changing the
behaviour of CLI 'info sources'?

Thanks,
Andrew


* Andrew Burgess <andrew.burgess@embecosm.com> [2021-05-19 12:12:37 +0100]:

> Thanks for all the great feedback.
> 
> In V2:
> 
>  - Documentation talks about object files rather than binaries, I also
>    fixed the other doc issues Eli pointed out.
> 
>  - Renamed the new quick function in patch #1 to
>    has_unexpanded_symtabs as suggested.  The resuling
>    objfile::has_unexpanded_symtabs function now has debug print out
>    like other quick function wrapper functions.
> 
>  - The commit message that adds the new MI option has some example
>    output.
> 
>  - Instead of adding a new option for CLI "info sources", the output
>    format has been changed.
> 
>  - Other minor code issues have been cleaned up.
> 
> Of note:
> 
>  - The new objfile::has_unexpanded_symtabs is still in symfile-debug.c
>    rather than objfile.c as Tom suggested.  This ensures that this
>    quick function wrapper is in the same source file as all the other
>    wrapper functions.  I think we should move all of them together, or
>    not at all, and if they do all move it feels like it should be a
>    separate, follow-up commit.
> 
> Thanks,
> Andrew
> 
> 
> ---
> 
> Andrew Burgess (5):
>   gdb: add new function quick_symbol_functions::has_unexpanded_symbols
>   gdb: make struct output_source_filename_data more C++ like
>   gdb/mi: add regexp filtering to -file-list-exec-source-files
>   gdb/mi: add new --group-by-objfile flag for
>     -file-list-exec-source-files
>   gdb: change info sources to group results by objfile
> 
>  gdb/ChangeLog                                 | 111 ++++++
>  gdb/NEWS                                      |  30 ++
>  gdb/doc/ChangeLog                             |  15 +
>  gdb/doc/gdb.texinfo                           | 166 +++++++--
>  gdb/dwarf2/read.c                             |  22 ++
>  gdb/mi/mi-cmd-file.c                          |  92 +++--
>  gdb/objfiles.h                                |   6 +
>  gdb/psympriv.h                                |   2 +
>  gdb/psymtab.c                                 |  18 +
>  gdb/quick-symbol.h                            |   6 +
>  gdb/symfile-debug.c                           |  25 ++
>  gdb/symtab.c                                  | 349 +++++++++++-------
>  gdb/symtab.h                                  |  59 +++
>  gdb/testsuite/ChangeLog                       |  19 +
>  .../gdb.base/info_sources_2-header.h          |  28 ++
>  gdb/testsuite/gdb.base/info_sources_2-lib.c   |  25 ++
>  gdb/testsuite/gdb.base/info_sources_2-test.c  |  26 ++
>  gdb/testsuite/gdb.base/info_sources_2.exp     | 169 +++++++++
>  gdb/testsuite/gdb.dwarf2/dw2-filename.exp     |   2 +-
>  gdb/testsuite/gdb.mi/mi-file.exp              |   2 +-
>  gdb/testsuite/gdb.mi/mi-info-sources-base.c   |  23 ++
>  gdb/testsuite/gdb.mi/mi-info-sources.c        |  25 ++
>  gdb/testsuite/gdb.mi/mi-info-sources.exp      | 177 +++++++++
>  23 files changed, 1205 insertions(+), 192 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp
> 
> -- 
> 2.25.4
>